chore: upgrade expo 54#1655
Closed
cimigree wants to merge 17 commits into
Closed
Conversation
…moves trailing space in nvm file.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
… to not scroll for category.
… for tests to make them less flaky
Merged
ErikSin
requested changes
Jan 26, 2026
ErikSin
left a comment
Contributor
There was a problem hiding this comment.
2 blocking comments.
- On doing some reading, I think we need to do expo upgrade first before doing the compiler. It looks like the configuration is done for the compiler out of the box in expo 54.
- We should try to properly implement edge to edge. If you don't mind, I can try to take this on (and do it as a PR ontop of this PR)
| "@wdio/spec-reporter": "9.16.2", | ||
| "@wdio/types": "9.16.2", | ||
| "babel-jest": "30.0.4", | ||
| "babel-plugin-react-compiler": "1.0.0", |
Contributor
There was a problem hiding this comment.
According to expo, the compiler is already configured in expo 54. So we shouldn't need this.
| export async function getExpoImageStorageSize( | ||
| imageURL: string, | ||
| ): Promise<number> { | ||
| let fileInfo: FileSystem.FileInfo; |
Contributor
There was a problem hiding this comment.
I think we should keep this type definition
|
|
||
| export function useKeyboardListener() { | ||
| const [keyboardVisible, setKeyboardVisible] = useState(false); | ||
| const [keyboardHeight, setKeyboardHeight] = useState(0); |
Comment on lines
+62
to
+65
| <SafeAreaView | ||
| edges={['bottom']} | ||
| style={{flex: 1, backgroundColor: MEDIUM_GREY}}> | ||
| <StatusBar barStyle="dark-content" /> |
Contributor
There was a problem hiding this comment.
I think we should reconsider this. The push from Android is to have edge-to-edge-display. What your doing is adding a status bar to the edge-to-edge to make it look like it is not edge-to-edge.
I understand that this is probably the easiest way but I think we should spend time looking into how to properly implement edge to edge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1647
stacked on top of #1651
Upgrades to Expo 54, the last Expo upgrade that does not force the new architecture.
The biggest differences are related to
Small Changes
.nvmrcfileScreenshots of Google Pixel 8a
Screenshot of Samsung A25
FYI:
I tested on all my emulators in Android studio with various sizes of phone from Android 30 - 35.