Repository navigation
Add a page for each team type (TK-01, TK-04, RO-03, VK-05) - #76
Merged
Merged
Conversation
The seed data linked to www.prosjektveiviseren.no, a guessed address that is not Digdir's and leads to an unrelated site. Prosjektveiviseren now links to prosjektveiviseren.digdir.no, the address the specification uses. Prosjektmandat loses its «Mal for prosjektmandat» link, since we don't know where the template lives. The tests use the reserved example.org instead of a real-looking address. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The team types had a description, what must be in place and their roles, but nowhere to read them. Each type now has a page at /organisering/team/typer/[id], under Team in the breadcrumbs: - what characterises the type and «Dette må på plass» (TK-01, TK-04); - the roles relevant for it, linking to each role (RO-03); - «Anbefalte verktøy», the tools meant for the type, with a pointer to Verktøykassen for the ones that suit all types (VK-05); - the active teams of the type, as team cards. There is no list of team types in the menu. The page is reached through the type's name: Tag takes an `href`, and the team type tags on the team page, role cards, role pages and tool pages link to it. The wizard's result links to the type it lands on. Team cards keep a plain tag, since the card itself is already a link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a page for each team type. Before this, nothing in the frontend let you read about a team type: you only saw its name as a tag, or one type at the end of the wizard. The prototype has no team type page either. The page is reached through links; there is no menu item or list page for now.
Requirements: TK-01, TK-04, RO-03, VK-05
Frontend
/organisering/team/typer/[id](typer/[id].astro):It sits under Team, so the breadcrumbs read
Team › Produktteamand the Team menu item stays current, with no change toNAV.Tagtakes anhref. With one, it renders as a link. Team type tags now link to the type's page on the team page, role cards, role pages and tool pages.Team cards keep a plain tag, because the whole card is already a link and links can't be nested.
The wizard's result links to the team type it lands on («Les mer om prosjektteam»).
Queries:
getTeamTypereads the type with its roles join.getTeamsOfTypeandgetToolsForTeamTypereuse the existing team and tool queries with a filter.Test data fix (its own commit)
www.prosjektveiviseren.no. That address isn't Digdir's and leads to an unrelated site.https://prosjektveiviseren.digdir.no/, the address the specification uses.example.orginstead.Existing databases keep the old link until
pnpm db:seed:reset.Tests
teamtype-id.test.ts: the sections, the queries (as the visitor, filtered by type), the links to roles, teams and tools, the empty states and the 404.pnpm test(CMS + frontend) andpnpm check:webpass.Not covered
TK-01 (Må) asks for «en liste over definerte teamtyper». Without an overview list it is still only partly covered. We chose to leave out a list page for now and can add one later.
🤖 Generated with Claude Code