Repository navigation
Conversation
The deploy to genki-test failed in preflight: Container Apps refuses a job whose init container asks for more CPU than its app containers together, and the pg-backup job's dump step asked for 0.5 against the upload container's 0.25. The upload container now gets 0.5 CPU and 1Gi. A template test checks every job's init containers against its app containers.
Contributor
Model reviewNo findings. WalkthroughThe test deploy failed in preflight because Container Apps refused the nightly pg-backup job: its
Reviewed at 0a07128 with claude-opus-5-5 in 0.5 min. Pushes are checked against open findings, and fixed ones are resolved. Add the label |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The test deploy of main (run 44555226999) failed before any change was applied. Container Apps refused the pg-backup job from #828: an init container may not ask for more CPU than the job's app containers together, and the
dumpstep asks for 0.5 CPU while theuploadcontainer had 0.25. The upload container now gets 0.5 CPU and 1Gi, which is a valid Consumption size and costs only while the nightly job runs.Risk
Low. Only the backup job's container size changes. The job runs once a night for a few minutes.
Undo
Revert this commit. The deploy will then fail again in preflight, so a revert also needs the dump step lowered to 0.25.
How it was tested
scripts/backups-alerts.test.ts: no job's init container asks for more CPU than its app containers together. It fails without the fix and passes with it.scripts/backups-alerts.test.tssuite passes (15 tests) against the compiled template.Checklist