Skip to content

fix(settings): keep theme previews independent of active theme #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Iflaqbhat wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix(settings): keep theme previews independent of active theme #2329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fac8b55
fix(settings): keep theme previews independent of active theme
Iflaqbhat Jun 21, 2026
b6d5995
test(settings): verify theme preview colors exist in palette
Iflaqbhat Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions apps/app/src/react-app/domains/settings/appearance/theme-section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ import {

type ThemeMode = AppearanceViewProps["themeMode"];

export const THEME_PREVIEW_CLASSES: Record<"light" | "dark", string> = {
light: "bg-white",
dark: "bg-black",
};

interface ThemeSectionProps
extends Pick<AppearanceViewProps, "busy" | "themeMode" | "setThemeMode"> {}

Expand Down Expand Up @@ -69,14 +74,14 @@ function ThemePicker(props: ThemePickerProps) {
value="light"
label={t("settings.theme_light")}
>
<ThemePreview value="light" className="bg-white" />
<ThemePreview value="light" className={THEME_PREVIEW_CLASSES.light} />
<ThemePickerLabel>{t("settings.theme_light")}</ThemePickerLabel>
</ThemePickerItem>
<ThemePickerItem
value="dark"
label={t("settings.theme_dark")}
>
<ThemePreview value="dark" className="bg-zinc-950" />
<ThemePreview value="dark" className={THEME_PREVIEW_CLASSES.dark} />
<ThemePickerLabel>{t("settings.theme_dark")}</ThemePickerLabel>
</ThemePickerItem>
</ToggleGroup>
Expand Down Expand Up @@ -116,8 +121,8 @@ function ThemePreview(props: ThemePreviewProps) {
>
{props.value === "system" && (
<div className="flex h-full">
<div className="w-1/2 bg-white" />
<div className="w-1/2 bg-zinc-950" />
<div className={cn("w-1/2", THEME_PREVIEW_CLASSES.light)} />
<div className={cn("w-1/2", THEME_PREVIEW_CLASSES.dark)} />
</div>
)}
</div>
Expand Down
19 changes: 19 additions & 0 deletions apps/app/tests/theme-preview.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import { describe, expect, test } from "bun:test";

import tailwindConfig from "../tailwind.config";
import { THEME_PREVIEW_CLASSES } from "../src/react-app/domains/settings/appearance/theme-section";

describe("theme picker previews", () => {
test("uses fixed light and dark preview colors", () => {
expect(THEME_PREVIEW_CLASSES.light).toBe("bg-white");
expect(THEME_PREVIEW_CLASSES.dark).toBe("bg-black");
});

test("uses colors defined by the Tailwind palette", () => {
for (const className of Object.values(THEME_PREVIEW_CLASSES)) {
const colorName = className.replace("bg-", "");

expect(Object.hasOwn(tailwindConfig.theme.colors, colorName)).toBe(true);
}
});
});