test: cover create/update with relationship includes#92
Open
Fivell wants to merge 1 commit into
Open
Conversation
Implement the four long-standing xit placeholders (2017-2018) that described create/update + assign-relationship + include-in-response but were never written: - VoiceInTrunkGroup POST + assign voice_in_trunks + include - SharedCapacityGroup POST + assign dids + include - VoiceInTrunk POST + assign pop + include - VoiceInTrunk PATCH + assign pop + include Uses request_includes to emit ?include= on writes and asserts the included resources deserialize into the associations without a second request. Fixtures captured from the live sandbox (GET ?include=), DID number normalized to a documentation placeholder. Suite: 532 examples, 0 failures, 0 pending (was 4 pending).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the four long-standing
xitplaceholders (dating back to 2017–2018) that described "create/update + assign relationship + include in response" but were never written:VoiceInTrunkGroupPOST + assignvoice_in_trunks+ includeSharedCapacityGroupPOST + assigndids+ includeVoiceInTrunkPOST + assignpop+ includeVoiceInTrunkPATCH + assignpop+ includeApproach
record.request_includes(:rel)to emit?include=on POST/PATCH, then asserts theincludedresources deserialize straight into the associations (no second HTTP request — WebMock would fail otherwise).GET …?include=(authentic JSON:API shape, identical to what POST/PATCH-with-include returns). The one real DID number was normalized to a documentation placeholder; no credentials/IPs/internal hosts present.Result
Suite: 532 examples, 0 failures, 0 pending (was 4 pending). Rubocop clean.