Skip to content

Unify store UI options#8627

Merged
glebm merged 1 commit into
diasurgical:masterfrom
glebm:store-style
Jul 16, 2026
Merged

Unify store UI options#8627
glebm merged 1 commit into
diasurgical:masterfrom
glebm:store-style

Conversation

@glebm

@glebm glebm commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Unifies "Show Item Graphics" and "Visual Store" boolean options into a single enum.

Also moves floating info box option next to the store UI option as they are somewhat related.

Unifies "Show Item Graphics" and "Visual Store" boolean options
into a single enum.

Also moves floating info box option next to the store UI option
as they are somewhat related.
@glebm
glebm enabled auto-merge (rebase) July 16, 2026 05:55
@yuripourre

yuripourre commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

@glebm this one could be controversial. Some people, when they are (store) farming for an specific item, need to know what is the position of the item in the list of items. And once you find it (if you can see the graphics) you know exactly how the item will look like.

Visual Store doesn't make clear the order of items.

I personally don't use the "Show Item Graphics" but I know some players do.

@glebm

glebm commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

@yuripourre This only changes 2 boolean options to a single 3-value enum option, it doesn't change what's available. The 2 boolean options didn't make sense because there were redundant option combinations:

Show Item Graphics Visual Store Result
Off Off Text store
On Off Text store with item graphics
On On Visual store
Off On Visual store

@yuripourre

Copy link
Copy Markdown
Collaborator

Oh, @glebm understood it now. When I read the description (without reading the code) I thought both options will become a single boolean.

My apologies.

@yuripourre yuripourre left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution!

@glebm
glebm merged commit f79af12 into diasurgical:master Jul 16, 2026
27 checks passed
@glebm
glebm deleted the store-style branch July 16, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants