fix: add custom attributes to data set section [DHIS2-7765]#970
fix: add custom attributes to data set section [DHIS2-7765]#970Sharmyn28 wants to merge 1 commit into
Conversation
✅ Deploy Preview for dhis2-maintenance-app-beta ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
tomzemp
left a comment
tomzemp
left a comment
There was a problem hiding this comment.
Looks good!
I wonder if we should change the attribute description from section to data set section (would be better in a separate ticket though as it would require a bunch of documentation updates)
Just while testing it, it made me realise that if you remove an attribute from a certain object, you can end up with "legacy" attribute values which we will not display. I think we probably want to address that, e.g. let you see what was previously saved and then remove it on save (this is not specific to this ticket, so I'll add it as a discussion point for one of our upcoming meetings)
|
|
||
| <CustomAttributesSection | ||
| schemaSection={dataSetSectionSchemaSection} | ||
| sectionedLayout={true} |
There was a problem hiding this comment.
this could also just be sectionedLayout which is more consistent with how it's written elsewhere in the app, but explicitly passing true also works
2 participants
Fix attribute:
DHIS2-7765
Custom attributes (data set section form)
