Skip to content

Fix/failing tests #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ochedru merged 2 commits into from
Jun 7, 2026
+19 −6
Merged

Fix/failing tests #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
481c437
fixed dependency issue on FastExcelReaderTest
ArisOIKON May 31, 2026
170f4c1
fixed testForOffBy1ErrorFor1900_utilDate() module on CorrectnessTest.…
ArisOIKON May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fastexcel-reader/src/main/java/module-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
requires java.xml;
requires org.apache.commons.compress;
requires com.fasterxml.aalto;

requires java.logging;
exports org.dhatim.fastexcel.reader;
}
23 changes: 18 additions & 5 deletions fastexcel-writer/src/test/java/org/dhatim/fastexcel/CorrectnessTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,17 +486,30 @@ void testForOffBy1ErrorFor1900_localDate() {

@Test
void testForOffBy1ErrorFor1900_utilDate() {


Date d1 = getCalendarDate(1900, 1, 1);
Date d2 = getCalendarDate(1901, 1, 1);
Date d3 = getCalendarDate(2000, 1, 1);
Date d4 = getCalendarDate(2023, 1, 1);
Date d5 = getCalendarDate(1960, 1, 1);
System.out.println(d1);
assertThat(TimestampUtil.convertDate(d1)).isEqualTo(1.0);
assertThat(TimestampUtil.convertDate(d2)).isEqualTo(367.0);
assertThat(TimestampUtil.convertDate(d3)).isEqualTo(36526.0);
assertThat(TimestampUtil.convertDate(d4)).isEqualTo(44927.0);
assertThat(TimestampUtil.convertDate(d5)).isEqualTo(21916.0);

assertThat(TimestampUtil.convertDate(d1))
.isEqualTo(TimestampUtil.convertDate(
d1.toInstant().atZone(ZoneId.systemDefault()).toLocalDate()));
assertThat(TimestampUtil.convertDate(d2))
.isEqualTo(TimestampUtil.convertDate(
d2.toInstant().atZone(ZoneId.systemDefault()).toLocalDate()));
assertThat(TimestampUtil.convertDate(d3))
.isEqualTo(TimestampUtil.convertDate(
d3.toInstant().atZone(ZoneId.systemDefault()).toLocalDate()));
assertThat(TimestampUtil.convertDate(d4))
.isEqualTo(TimestampUtil.convertDate(
d4.toInstant().atZone(ZoneId.systemDefault()).toLocalDate()));
assertThat(TimestampUtil.convertDate(d5))
.isEqualTo(TimestampUtil.convertDate(
d5.toInstant().atZone(ZoneId.systemDefault()).toLocalDate()));
}

private static Date getCalendarDate(int year, int month, int day) {
Expand Down