Fix: resolve Alarm Button CSP block, scope issues, and audio crash#7271
Open
Souma-122s wants to merge 4 commits into
Open
Fix: resolve Alarm Button CSP block, scope issues, and audio crash#7271Souma-122s wants to merge 4 commits into
Souma-122s wants to merge 4 commits into
Conversation
|
@Souma-122s is attempting to deploy a commit to the Dhairya Gothi 's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Pull Request Description
Related Issue
Closes #6960
Summary
This PR resolves the critical failure of the "ADD ALARM" button on the Digital Clock project. The root cause was Vercel's strict Content Security Policy (CSP) blocking inline HTML
onsubmitandonclickattributes. While addressing this, I also debugged and resolved related scope issues, fixed and audio crash and implemented the missing history logging architecture.Type of Change
🛠️ Changes Made
onsubmit/onclickinline scripts and implemented safe nativeaddEventListenerlogic for the alarm buttons.DOMContentLoadedevent that was accidentally isolating global functions (like Dark Mode and World Clock).ReferenceErrorcrashing thetriggerAlarmfunction before the.play()method could execute.addHistoryLogfunction and formatted the output as an object ({text: message}) to resolve theundefinedrendering bug.🧪 Testing and Verification
Local Validation
node scripts/validateProjects.jslocally and it passed with zero errors.Browser Compatibility Check
Responsive & Accessibility Checks
🤝 Contributor Checklist