Skip to content

fix: add accessibility improvements under to-do list - resolves #3099#3282

Open
aaradhyasinghai-ux wants to merge 5 commits into
dhairyagothi:Mainfrom
aaradhyasinghai-ux:fix/accessibility-improvements
Open

fix: add accessibility improvements under to-do list - resolves #3099#3282
aaradhyasinghai-ux wants to merge 5 commits into
dhairyagothi:Mainfrom
aaradhyasinghai-ux:fix/accessibility-improvements

Conversation

@aaradhyasinghai-ux
Copy link
Copy Markdown

TO-DO LIST FIXES -

[ ] FIX 1 — aria-label added to 5 theme buttons (section 1)
[ ] FIX 2 — sr-only label + aria-label added to input & select (section 1)
[ ] FIX 3 — aria-label on Add Task + Save PDF buttons, aria-hidden on icons (section 1)
[ ] FIX 4 — sr-only label + aria-label added to input & select (section 2)
[ ] FIX 5 — aria-label on Add Task + Save PDF buttons (section 2)
[ ] FIX 6 — role + aria-label on 3 drop zones (section 2)
[ ] FIX 7 — role + aria attributes on progress bar (section 2)
[ ] FIX 8 — .sr-only CSS added to todolist.css

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

@aaradhyasinghai-ux is attempting to deploy a commit to the Dhairya Gothi 's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@aaradhyasinghai-ux
Copy link
Copy Markdown
Author

Hey @dhairyagothi,
I have completed the accessibility improvements and raised the PR.
Merge conflicts have also been resolved successfully. Kindly review it. Thank you!

@dhairyagothi
Copy link
Copy Markdown
Owner

Mention the issue no on which you have worked

Don't raise PR against the issue which is not assigned to you and without raising issue

@aaradhyasinghai-ux
Copy link
Copy Markdown
Author

Hi @dhairyagothi, I have worked on Issue #3099, which was assigned to me by you, and raised the PR for it.
Merge conflicts have also been resolved successfully.
Kindly review it when possible.

@dhairyagothi dhairyagothi added gssoc:approved Approved by admin level:advanced Advanced difficulty task type:refactor Refactoring/improvement labels May 25, 2026
@github-actions github-actions Bot added the merge-conflicts Pull request has merge conflicts label May 27, 2026
@aaradhyasinghai-ux
Copy link
Copy Markdown
Author

Hi @dhairyagothi,
Merge conflicts have been resolved successfully.
Kindly review it when possible.

@dhairyagothi
Copy link
Copy Markdown
Owner

Please resolve merge conflicts before this PR can be merged.

Comment thread public/TO_DO_LIST/todolist.html Fixed
@aaradhyasinghai-ux
Copy link
Copy Markdown
Author

Hey @dhairyagothi, resolved the merge conflicts in both files.
For todolist.css, accepted both changes since the .sr-only class I added and the reset styles from Main don't interfere with each other. For todolist.html, kept my branch's version as it has the accessibility attributes (aria-label, semantic IDs) that this PR is built around.
Let me know if anything looks off!

@aaradhyasinghai-ux
Copy link
Copy Markdown
Author

Hey @dhairyagothi,
Resolved the merge conflicts, Please review the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved Approved by admin level:advanced Advanced difficulty task merge-conflicts Pull request has merge conflicts type:refactor Refactoring/improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants