🎨 Palette: [UX improvement] Add focus-visible styling to utility icon buttons#68
Conversation
… buttons - Added explicit `focus-visible` ring styling to various close, cancel, edit, and delete icon buttons. - These buttons often have subtle or transparent styling which makes default browser focus rings hard to see, hindering keyboard navigation. - Included buttons in LiveTracking, VehicleSelectModal, SaveAddressDialog, FuelCart, CheckoutOffersSheet, Garage, NotificationToast, Favorites, and BulkOrder. - Added `aria-label` to the remove item button in BulkOrder. - Documented learning in `.jules/palette.md`. Co-authored-by: DhaatuTheGamer <90041791+DhaatuTheGamer@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What:
Added explicit keyboard focus styling (
focus-visible:ring-2 focus-visible:ring-primary focus-visible:outline-none rounded-sm) to secondary utility icon buttons across the application (e.g., 'X' to close modals, 'Trash' to delete items, 'Edit' pens).🎯 Why:
Because these utility buttons often have transparent backgrounds and rely on subtle hover effects in the brutalist design system, the default browser focus ring is either insufficient, hidden, or clashing. This makes it very difficult for keyboard users and those relying on assistive technologies to see which utility action is currently focused, particularly inside complex components like lists or modals.
📸 Before/After:
Before: Tabbing to the edit or delete icon button on a saved favorite would not provide a clear visual indicator that the button was focused.
After: Tabbing to these buttons now shows a clear, primary-colored focus ring that matches the button's border radius, making navigation clear.
♿ Accessibility:
aria-labelto the 'Remove item' button within the BulkOrder component.PR created automatically by Jules for task 1244639872652554326 started by @DhaatuTheGamer