Allow partial configuration overrides in environments#14
Conversation
Modified 'config/config_manager.py' to add default values to all required fields in sub-models. This allows Pydantic to successfully parse partial environment overrides (e.g., in the 'development' environment) without requiring all fields to be redefined. To maintain configuration integrity, a root validator was added to the 'RobotMCPConfig' model. This validator ensures that essential configuration components (such as at least one workspace and one LLM provider) are present in the final merged configuration. Added 'tests/test_config_manager.py' to verify the fix and ensure that invalid configurations (e.g., missing workspaces) are still correctly identified. Co-authored-by: dgaida <23057824+dgaida@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Modified 'config/config_manager.py' to allow partial environment overrides by providing default values for configuration sub-models. A root validator ensures the final merged configuration remains valid. Fixed linting issues in 'tests/test_config_manager.py' by removing unused imports and re-sorting the remaining ones. Added docstrings for test functions. Co-authored-by: dgaida <23057824+dgaida@users.noreply.github.com>
Modified 'config/config_manager.py' to allow partial environment overrides by providing default values for configuration sub-models. A root validator ensures the final merged configuration remains valid. Fixed linting and formatting issues in 'tests/test_config_manager.py' using Ruff and Black. Added docstrings for test functions. Co-authored-by: dgaida <23057824+dgaida@users.noreply.github.com>
dgaida
deleted the
fix-config-validation-overrides-7219050813307336781
branch
1 participant
This change fixes the configuration validation errors reported by the user when running with environment overrides. By adding default values to sub-models and using a root validator for the final merged state, we now support flexible partial overrides while ensuring the system always starts with a valid total configuration.
PR created automatically by Jules for task 7219050813307336781 started by @dgaida