Skip to content

allow usb_reset on DfuIo / DfuAsyncIo to accept &mut self#31

Merged
cecton merged 4 commits into
dfu-rs:mainfrom
genkiinstruments:usb-reset-mut-self
Dec 9, 2025
Merged

allow usb_reset on DfuIo / DfuAsyncIo to accept &mut self#31
cecton merged 4 commits into
dfu-rs:mainfrom
genkiinstruments:usb-reset-mut-self

Conversation

@dingari

@dingari dingari commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

Related: dfu-rs/dfu-nusb#6

On macOS, nusb will fail to reset the device while interfaces are claimed. DfuNusb needs to explicitly drop the interface, and thus needs &mut self.

@cecton

cecton commented Dec 8, 2025

Copy link
Copy Markdown
Member

Hello and thank you so much for your contribution 🙏

I wanted to fix the test myself but I think you didn't allow pushing on your branch PR maybe? You can either allow the maintainers to push or push yourself.

Have a nice day

@dingari

dingari commented Dec 8, 2025

Copy link
Copy Markdown
Contributor Author

I don't see the "Allow edits from maintainers..." checkbox, probably since this is an organization-owned fork. But I've added your account as a collaborator so you should be able to push :)

@dingari

dingari commented Dec 8, 2025

Copy link
Copy Markdown
Contributor Author

I guess I didn't run the tests with async feature. Sorry about that!

@dingari

dingari commented Dec 8, 2025

Copy link
Copy Markdown
Contributor Author

But it's an easy enough fix, I'll just push the change myself :)

@cecton

cecton commented Dec 9, 2025

Copy link
Copy Markdown
Member

I don't see the "Allow edits from maintainers..." checkbox, probably since this is an organization-owned fork. But I've added your account as a collaborator so you should be able to push :)

I'm not sure. On other PR I could push stuff for some reason. Like the PR 28 🤷‍♀️ GitHub

@cecton cecton merged commit b98df12 into dfu-rs:main Dec 9, 2025
3 checks passed
@cecton

cecton commented Dec 9, 2025

Copy link
Copy Markdown
Member

Released in v0.9.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants