allow usb_reset on DfuIo / DfuAsyncIo to accept &mut self#31
Conversation
|
Hello and thank you so much for your contribution 🙏 I wanted to fix the test myself but I think you didn't allow pushing on your branch PR maybe? You can either allow the maintainers to push or push yourself. Have a nice day |
|
I don't see the "Allow edits from maintainers..." checkbox, probably since this is an organization-owned fork. But I've added your account as a collaborator so you should be able to push :) |
|
I guess I didn't run the tests with |
|
But it's an easy enough fix, I'll just push the change myself :) |
I'm not sure. On other PR I could push stuff for some reason. Like the PR 28 🤷♀️ GitHub |
|
Released in v0.9.2 |
Related: dfu-rs/dfu-nusb#6
On macOS,
nusbwill fail to reset the device while interfaces are claimed.DfuNusbneeds to explicitly drop the interface, and thus needs&mut self.