Skip to content

(add): inter-canister-calls example added#74

Open
mzurs wants to merge 3 commits into
dfinity:mainfrom
mzurs:main
Open

(add): inter-canister-calls example added#74
mzurs wants to merge 3 commits into
dfinity:mainfrom
mzurs:main

Conversation

@mzurs

@mzurs mzurs commented May 31, 2025

Copy link
Copy Markdown

Added a new example to the bucket.

The compiled WASM module and candid interfaces are being taken from the dfinity official example repo -> https://github.com/dfinity/examples/tree/master/rust/inter-canister-calls

@mzurs mzurs requested a review from a team as a code owner May 31, 2025 02:32
@github-actions

Copy link
Copy Markdown

Thank you for contributing! Unfortunately this repository does not accept external contributions yet.

We are working on enabling this by aligning our internal processes and our CI setup to handle external contributions. However this will take some time to set up so in the meantime we unfortunately have to close this Pull Request.

We hope you understand and will come back once we accept external PRs.

— The DFINITY Foundation"""

@github-actions github-actions Bot closed this May 31, 2025
@mzurs

mzurs commented May 31, 2025

Copy link
Copy Markdown
Author

@mraszyk @jwndlng, can you please confirm if external contributions are allowed, as I thought this repository was open to external contributions? Thanks!

@mzurs mzurs changed the title (add): inter-canister-calls exmaple added (add): inter-canister-calls example added May 31, 2025
@fxgst

fxgst commented Jun 2, 2025

Copy link
Copy Markdown
Contributor

@mzurs thank you for your contribution. We're making the repository accept external contributions in a moment. I'll update here once it accepts contributions. Sorry for the delay!

@fxgst fxgst reopened this Jun 2, 2025
Comment thread examples/inter_canister_calls/caller.did Outdated

@fxgst fxgst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run this example on CI by adding a line here

mzurs and others added 2 commits June 2, 2025 16:00
Co-authored-by: Elias Datler <46360620+fxgst@users.noreply.github.com>
@mzurs

mzurs commented Jun 2, 2025

Copy link
Copy Markdown
Author

In the context of adding multiple examples in CI, it would be great if we could add the script to run all examples.

import os
import subprocess

def run_tests_in_examples():
    examples_dir = os.path.join(os.getcwd(), "examples")
    for root, _, files in os.walk(examples_dir):
        for file in files:
            if file.endswith("_test.py"):
                test_file_path = os.path.join(root, file)
                print(f"Running test: {test_file_path}")
                subprocess.run(["python3", test_file_path], check=True)

if __name__ == "__main__":
    run_tests_in_examples()

@mzurs mzurs requested a review from fxgst August 1, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants