Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Thanks @pr4bh4sh, nice work. I approved the workflow run and it's all green:
I also ran the CDP package locally with One request before merging: since the shard package lists are static, could you add a step that fails CI when a package isn't covered by any shard? Otherwise a package added later would silently never be tested. Something like: go list ./... | sort > all.txt
printf '%s\n' <all shard package lists> | tr ' ' '\n' | sort -u > sharded.txt
diff -u all.txt sharded.txtA small nit, optional: Happy to merge once the coverage check is in. |
Summary
cdp,s1,s2,s3).-parallel 4.Validation
go test ./... -run '^$'go test ./pkg/driver/browser/cdp -parallel 4 -timeout 25m -coverprofile=coverage-cdp.out -covermode=atomic— passed in 3m 06s with 80.9% coveragegofmtandgit diff --checkRelated tracking issue: pr4bh4sh#9