Skip to content

build: proxy settings for build and devcontainer - #724

Draft
nbmaiti wants to merge 1 commit into
mainfrom
proxy_setting
Draft

nbmaiti wants to merge 1 commit into
mainfrom
proxy_setting

Conversation

@nbmaiti

@nbmaiti nbmaiti commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

-> devcontainer go version updated to 1.25
-> devcontainer updated to include proxy settings
-> build script support proxy build

@nbmaiti
nbmaiti requested review from Copilot and rsdmike December 12, 2025 10:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds proxy server support to both the build process and development container configuration, while also updating the development container's Go version from 1.x to 1.25.

  • Proxy environment variables (HTTP_PROXY, HTTPS_PROXY, NO_PROXY) are now configured and passed to Docker builds
  • Development container updated to Go 1.25 on Debian Trixie base image
  • Proxy settings automatically inherited from host environment in devcontainer

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
build.sh Added proxy environment variable handling and passed build args to Docker
.devcontainer/devcontainer.json Updated Go version to 1.25, added proxy environment configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread build.sh Outdated
Comment thread build.sh Outdated
Comment thread .devcontainer/devcontainer.json Outdated
Comment thread .devcontainer/devcontainer.json Outdated
@codecov

codecov Bot commented Dec 12, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.99%. Comparing base (a423c5d) to head (d3aa129).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #724   +/-   ##
=======================================
  Coverage   61.99%   61.99%           
=======================================
  Files         158      158           
  Lines       13337    13337           
=======================================
  Hits         8268     8268           
  Misses       5069     5069           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread build.sh
@nbmaiti
nbmaiti force-pushed the proxy_setting branch 2 times, most recently from 8ad6bb9 to 0b40dc0 Compare January 12, 2026 16:42
@nbmaiti
nbmaiti force-pushed the proxy_setting branch 3 times, most recently from aaaceea to 903aaf1 Compare February 25, 2026 18:30
@nbmaiti
nbmaiti marked this pull request as draft October 6, 2026 03:14
  -> devcontainer go version updated to 1.25
  -> devcontainer updated to include proxy settings
  -> build script support proxy build

Signed-off-by: Nabendu Maiti <nabendu.bikash.maiti@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants