Repository navigation
Drop the base checkout of commit boards - #1431
Merged
Merged
Conversation
Since #1175 the base side of a diff has no language features, so the base checkout under .git/dev-fast/reviews/<uuid>/base had no reader left but Source windows opened from the base side. Workspaces now prepare one environment per board, the head; the checkout helpers lose their role. Agent-Session: f949acce-5c96-46f0-92af-57fc57a137fd Agent-Session: 8625c3c9-675e-4237-9d72-b6ea7df04976 Agent-Session: 778ba399-e5fb-4c16-a31b-3c8632db2fcd Agent-Session: fea01a6a-bba5-4058-b6c6-dbaccc15cd9c Agent-Session: 5625cb14-3381-4fef-8d68-2cdc27ef7155 Agent-Session: 283ceb25-3b3b-471c-b900-b0a825d8588b Agent-Session: 4e9794ef-5a99-4635-ae45-1af0c43d14da
Rows written with role "base" and their worktrees are removed on the next start; the head row and checkout of the same board stay. Agent-Session: f949acce-5c96-46f0-92af-57fc57a137fd Agent-Session: 8625c3c9-675e-4237-9d72-b6ea7df04976 Agent-Session: 778ba399-e5fb-4c16-a31b-3c8632db2fcd Agent-Session: fea01a6a-bba5-4058-b6c6-dbaccc15cd9c Agent-Session: 5625cb14-3381-4fef-8d68-2cdc27ef7155 Agent-Session: 283ceb25-3b3b-471c-b900-b0a825d8588b Agent-Session: 4e9794ef-5a99-4635-ae45-1af0c43d14da
thesiti92
force-pushed
the
chore/drop-base-checkout
branch
from
October 27, 2026 18:21
290dfe9 to
42075dc
Compare
sidkmenon
approved these changes
Oct 27, 2026
thesiti92
enabled auto-merge (squash)
October 27, 2026 18:30
environmentIssues is {message}[]. The language-context and navigator routes
take no side; a base-side Source window opens the head checkout and the
file's head counterpart. The fork stops sending the side.
Agent-Session: f949acce-5c96-46f0-92af-57fc57a137fd
Agent-Session: 8625c3c9-675e-4237-9d72-b6ea7df04976
Agent-Session: 778ba399-e5fb-4c16-a31b-3c8632db2fcd
Agent-Session: fea01a6a-bba5-4058-b6c6-dbaccc15cd9c
Agent-Session: 5625cb14-3381-4fef-8d68-2cdc27ef7155
Agent-Session: 283ceb25-3b3b-471c-b900-b0a825d8588b
Agent-Session: 4e9794ef-5a99-4635-ae45-1af0c43d14da
Agent-Session: bbe68e6e-ff83-4042-93bf-6f0b489709f8
Agent-Session: bba1f35a-83e9-4d5d-be0e-76742d0c87f8
thesiti92
force-pushed
the
chore/drop-base-checkout
branch
from
October 27, 2026 18:43
42075dc to
bffa162
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every commit or PR board created two detached worktrees of the repository under
.git/dev-fast/reviews/<uuid>/: the head and the base. For a large monorepo each one is a full tree on disk. Since #1175 the base side of a diff has no language features, so the base checkout served only Source windows opened from the base side of a diff.What
ReviewWorkspacesprepares one environment per board, the head.open()is gone;source(reviewId, pins)has no side. Rows and worktrees with the legacyrole: "base"are collected on the next start, so existing users reclaim the disk without doing anything. Thehead/<sha>path segment stays so existing head checkouts survive the upgrade.environmentIssues(review_open, review_environment) is{message}[]. Thelanguage-contextandnavigatorroutes drop thesidequery; the fork no longer sends it.ensureReviewPinnedCheckoutandreviewManagedCheckoutDirlose their role parameter.Tests
pnpm lint,pnpm format:check, review package typecheck and the fork typecheck pass.src/cli-install.test.ts"runs a matched CLI and runtime with healthy discovery" fails identically on an unchanged origin/main worktree on this machine.Follow-ups, not in this PR: create the head checkout on demand instead of on open, and point diffr at the git dir (verified: identical tree-mode output from a checkout, its
.gitdir and a bare clone).