Skip to content

Feature/dashboard UI refactor - #46

Merged
Shakibuzzaman3104 merged 14 commits into
release/1.3.3from
feature/dashboard-ui-refactor
Sep 28, 2026
Merged

Shakibuzzaman3104 merged 14 commits into
release/1.3.3from
feature/dashboard-ui-refactor

Conversation

@maksudur03

Copy link
Copy Markdown
Collaborator

What

Reworks the web dashboard's Network detail pane, then fixes what surfaced while driving both
inspectors on a device. One commit per point:

  • Declutter the Network detail pane (78509fe, docs in 743b13d / 12b9c2c) — the head's
    facts strip folds into a Summary tab that now leads the tab row, and seven actions move from a
    flat row into a kebab (⋮) menu. The compare panes drop their duplicated "General" group.
    DESIGN_SPEC.md gains §4a for the resulting anatomy.
  • Stop labelling array elements as object keys (12d678c) — the JSON tree flattens arrays into
    [key, value] pairs for diff addressing, and was printing that index as "0":. An index is a
    position, not a field name; Compose never had this.
  • Wrap long URLs instead of cutting them (8e7fd0a) — Network rows wrap paths over four lines
    then ellipsise, on web and Android. On web, status now sits above duration in one auto-width
    column, handing ~70px back to the path. Required teaching the list virtualizer measured row
    heights.
  • Embed JSON bodies as JSON when sharing (ba15c2a) — "share as JSON" quoted a JSON body into
    the document, so it arrived as a wall of \". Now inlined as real JSON on the network,
    WebSocket-frame and log detail screens. Same commit splits the sample's request card into GET and
    POST so captures carry a request body.
  • Fix the mock editor's keyboard handling (d52947b) — the activity declares adjustResize, so
    the keyboard stops panning the window while imePadding() added a second keyboard's worth of
    padding underneath; the editor header stops applying the status-bar inset twice; single-line
    fields get ImeAction.Done; the Save bar stands down while typing. Adds full-screen body editing
    that shares one editing session with the inline field.
  • Add Pretty view to the expanded body (0bbd556) — expanding a body forced Raw, losing the
    collapsible tree at the size where structure matters most. The overlay now carries the same
    Pretty/Raw toggle and opens in whichever mode the pane was showing.

Verification

  • ./gradlew testDebugUnitTest — passing
  • ./gradlew ktlintCheck detekt — clean, nothing baselined away
  • ./gradlew apiCheck — clean; no public API changed
  • :samples:compose-app:assembleRelease :verifyDevConsoleProtectedArtifacts — run because this
    edits the sample; release artifact clean

New tests cover the two pure helpers (share-as-JSON embedding, URL line breaking). Everything else
was checked on a physical device and in a browser by asserting state, not by eye: a 4000-row scroll
sweep at nine positions, dumpsys confirming adjust=resize, uiautomator for footer/pill
visibility, and Pretty → collapse → Raw → close leaving the pane underneath intact.

Checklist

  • No capture-path code changed — inspector UI, dashboard assets, share formatting, sample only
  • No new sensitive data exported — snippets format already-redacted fields; the sample's test
    URL avoids every name on RedactionPolicy.default()
  • Docs updated — DESIGN_SPEC.md §4a
  • Scoped to one logical change — no, it is a refactor plus five follow-up fixes, each its
    own commit. Happy to split if you'd rather review them separately.

Anything reviewers should look at closely

The virtualizer rewrite (createVirtualList). It assumed uniform --d-row-h rows and built
spacers as count * rowH; it now measures per-row heights with lazily-rebuilt prefix sums, binary
search, and a bounded corrective repaint that holds the anchor row's scroll position. It backs all
five list views and the web side has no test infrastructure, so the scroll sweep is the only guard.
An early version painted a blank frame on fast scrolls (34px estimate vs 46px real), which is why
the estimate self-calibrates to the shortest measured row.

Two smaller calls: the full-screen overlay caches its tree under a separate 'fs:' key, because a
cached tree is a live DOM node and reusing the inline one would move it out of the pane behind it;
and breakingAnywhere() inserts U+2060 WORD JOINER into the Android row's displayed path so lines
fill instead of breaking early — display-only, but it does put invisible characters in rendered
text, and Compose has no break-all equivalent.

Not verified on device: the plain code-block path in the expanded view (mock preview, remote config
value) where the toggle should stay hidden, and XML bodies.

🤖 Generated with Claude Code

Munif and others added 14 commits August 25, 2026 11:49
The Network detail head had grown three stacked strips above the tabs — a
facts row, an actions row, and the tabs themselves — pushing the request and
response panes well down the viewport. Each strip also duplicated something
already on screen: the facts repeated what the compare panes' "General" groups
showed, and the actions row spent a full row on buttons that are used
occasionally, not per-capture.

Consolidate onto the Summary tab and a kebab menu:

- Move the facts strip (time, duration, content type, correlation, mock rule,
  vs-original) out of the head and into Summary, where the mock rule keeps its
  link into Mocks via a new `mockRuleLink` kv-grid row type.
- Drop the "General" group from both compare panes. Everything it held now
  lives in Summary, so the tab is just headers and body.
- Give the failure branch's error string its own `response.error` Summary row
  instead of parenthesising it into `response.status`; it was previously only
  reachable through the General group that just went away.
- Replace the actions row with a kebab (⋮) menu beside the expand button.
  Opt-in per pane via `actionsMenu`, so WebSockets/Push/Crashes — two or three
  actions each — keep their flat rows. Items carry the same
  `data-detail-action` ids, so the existing delegated handlers are unchanged.
  Closes on pick, outside click, and Escape.
- Order Summary first among the tabs. Default selection is still
  Request & response.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The spec's Network entry still described a "detail action row (Clone to
composer, cURL, fetch, JSON, Related events)" that predates the current
actions/tabs split, and nothing documented the detail pane's anatomy at all —
so the previous commit's rearrangement had no spec to disagree with.

Add §4a covering the shared head (badge/title/status/expand), the two variants
of its middle band (Network's kebab menu vs. the other panes' flat actions
row), Network's tab order and why Summary leads while Request & response stays
the default selection, the absent "General" group, group collapse defaults,
and Simple-mode hiding.

Also correct three stale claims while in here: §5 named `.list`/`.detail-pane`
(now `.list-pane`/`.detail-pane-v2` inside `.split-shell`), §6's Network
toolbar list omitted the service dropdown and More-filters disclosure, and the
new §4a records that Timeline hand-rolls its own head instead of using
`detailHeadHtml` — logged as an open item rather than left as a silent drift.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
- Split the packaged scan per format: verify<Variant>DevConsolePackagedArtifact
  (APK/AAR, assemble path) and verify<Variant>DevConsolePackagedBundle (AAB,
  bundle path). One task naming both built an AAB during every release APK
  build, which broke Studio's signing wizard: -Pandroid.injected.apk.location
  puts the final AAB inside package<Variant>'s output dir, so Gradle rejects
  produce<Variant>BundleIdeListingFile for an undeclared dependency.
- Treat scan-limit-exceeded as a warning, not a violation. R8's mapping file
  overran the 64 MiB read cap and failed real release builds.
- Skip BUNDLE-METADATA/ entries: Play strips them, and proguard.map names every
  class the build ever saw.
- Warn instead of throwing FileNotFoundException on a missing or unreadable
  package.
- Match forbidden paths at any segment, so assets/devconsole-web/ is also found
  at base/assets/devconsole-web/ inside an AAB.
- Add devConsole.verificationEnabled / -Pdevconsole.verification.enabled=false
  to take verification off assemble/bundle, warning loudly and leaving
  verifyDevConsoleProtectedArtifacts runnable by name.

Tests: 11 new functional tests, 42/42 pass. Verified against a real app on both
assembleLiveRelease and bundleLiveRelease with the wizard's injected location.
The box borders didn't line up: the 🔍 and 🔒 emoji are double-width, so the
lines carrying them ran two columns past the frame while every other row sat
short of it. Dropped both emoji and repadded every line to a uniform 62-column
interior, verified by measuring East Asian width rather than counting
characters.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
… default

- Add fallback using document.execCommand('copy') when navigator.clipboard or window.isSecureContext is unavailable (e.g. over plain HTTP on LAN)
- Route copyStateJson and copyTableCsv through copyToClipboard with user toast feedback
- Remove authorization headers and Bearer regex pattern from default redaction policy to allow inspecting and copying authorization tokens by default during debugging
- Update documentation in SECURITY_AND_REDACTION.md and THREAT_MODEL.md
- Update unit tests across SDK modules and add regression tests for clipboard copy fallback

Fixes #40
Both list surfaces rendered only the captured path, so two calls to the
same endpoint -- /orders?status=open and /orders?status=all -- were two
identical rows and had to be opened one by one to be told apart. The
query was captured and redacted all along; it just never reached the row.

- Add NetworkUrl.queryString (the redacted `a=1&b=2` form display already
  built inline) and emit it as "query" beside "path" in the network list
  summary JSON, mirrored byte-for-byte in the evidence snapshot
- Web: rowHtml gains an optional mainSub, and Network rows pass the query
  into it -- dimmed after the path, with a title carrying both in full,
  so the endpoint stays the part that survives the row's ellipsis
- Device: pathWithQuery() reads the query back off the transaction url
  and titles the traffic row with it; traffic search matches the query,
  and the two url.ifBlank fallbacks no longer drop it

path itself stays bare everywhere: mock-rule prefill escapes it into a
regex, and the path= filter and path facets group on the endpoint alone.
InspectorTransactionUi deliberately gains no field for the same reason --
widening that data class would break its constructor and copy signatures
for every compiled caller, and url already carries the query.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NPxRnPJNgsb3y455VCrDGU
…uth-token-access

fix: support console clipboard copy fallback and unredacted auth tokens by default
…r-blocks-release

fix: never let verification block a release build
Add separate create and post request at sample screen
@maksudur03 maksudur03 self-assigned this Sep 28, 2026
@Shakibuzzaman3104
Shakibuzzaman3104 merged commit 401bf1a into release/1.3.3 Sep 28, 2026
1 check passed
nur-shuvo added a commit that referenced this pull request Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants