Repository navigation
fix: never let verification block a release build - #43
Merged
Merged
Conversation
- Split the packaged scan per format: verify<Variant>DevConsolePackagedArtifact (APK/AAR, assemble path) and verify<Variant>DevConsolePackagedBundle (AAB, bundle path). One task naming both built an AAB during every release APK build, which broke Studio's signing wizard: -Pandroid.injected.apk.location puts the final AAB inside package<Variant>'s output dir, so Gradle rejects produce<Variant>BundleIdeListingFile for an undeclared dependency. - Treat scan-limit-exceeded as a warning, not a violation. R8's mapping file overran the 64 MiB read cap and failed real release builds. - Skip BUNDLE-METADATA/ entries: Play strips them, and proguard.map names every class the build ever saw. - Warn instead of throwing FileNotFoundException on a missing or unreadable package. - Match forbidden paths at any segment, so assets/devconsole-web/ is also found at base/assets/devconsole-web/ inside an AAB. - Add devConsole.verificationEnabled / -Pdevconsole.verification.enabled=false to take verification off assemble/bundle, warning loudly and leaving verifyDevConsoleProtectedArtifacts runnable by name. Tests: 11 new functional tests, 42/42 pass. Verified against a real app on both assembleLiveRelease and bundleLiveRelease with the wizard's injected location.
maksudur03
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.