Skip to content

Feature/dashboard UI refactor - #35

Merged
Shakibuzzaman3104 merged 3 commits into
release/1.3.2from
feature/dashboard-ui-refactor
Aug 25, 2026
Merged

Shakibuzzaman3104 merged 3 commits into
release/1.3.2from
feature/dashboard-ui-refactor

Conversation

@maksudur03

Copy link
Copy Markdown
Collaborator

What

Declutters the Network detail pane. Five changes:

  • Move the head's facts line into Summary — time, duration, content type, correlation, mock rule
  • Remove the "General" group from both the Request and Response panes — Summary now holds
    everything it showed. Headers stay collapsed, payload/body expanded (already the default).
  • Give the error string a Summary row (response.error) — General was its only home before,
    and General is gone.
  • Fold the action buttons into a ⋮ menu at the top right, next to the expand button; click
    opens the list.
  • Put Summary first in the tab order.

Web assets only (dashboard.js, dashboard.css, index.html); no Kotlin, no API surface, no
capture-path code.

Verification

Which ./gradlew commands did you run, and what did they confirm? (See
CONTRIBUTING.md for the standard set.)

  • ./gradlew :sdk:server-ktor:test — passing (includes DashboardAssetsTest, the CSP guard
    that fails the build on inline scripts/handlers in these assets)
  • ./gradlew :sdk:server-ktor:ktlintCheck :sdk:server-ktor:detekt apiCheck — clean
  • ./gradlew ktlintCheck detekt (repo-wide) — fails on two pre-existing issues outside this
    diff
    , both in files this PR does not touch (and which Kotlin lint could not be affected by,
    since this diff is .js/.css/.html only):
    - samples/foundation-app/.../MainActivity.kt:335,504 — 4 ktlint violations
    - sdk/server-api/.../LocalServerEngine.kt:205 — detekt TooManyFunctions on
    SessionAuthority (13/11)
  • ./gradlew apiCheck — clean; no public API change, so no apiDump needed
  • Debug/release boundary: not touched, no sample assemble/verify needed

Checklist

  • Capture-path code (network/socket/push) never throws into the host app — not touched
  • No new sensitive data is captured, logged, or exported without going through
    RedactionEngine first — this only rearranges fields the pane already received and
    displayed; the redaction footnote is unchanged
  • Docs updated — docs/DESIGN_SPEC.md §4 describes the detail-pane layout and now trails the
    code on the facts strip and actions row. Happy to update it here or in a follow-up, reviewer's
    call.
  • This PR is scoped to one logical change

Anything reviewers should look at closely

  • The kebab is opt-in, not global. detailHeadHtml gained an actionsMenu flag that only
    renderNetworkDetail passes; WebSockets/Push/Crashes carry two or three actions each and keep
    their flat rows, where a menu would only add a click. One line each to flip them if you'd rather
    the chrome be uniform.
  • .detail-menu-panel is position: fixed, placed by positionDetailMenuPanel(). It has to
    be — .detail-pane-v2 is overflow: hidden, so an absolutely positioned popup clips at the pane
    edge. Same trade the toolbar .drop-panel dropdowns already make.
  • Menu items keep their data-detail-action ids, so the existing delegated click handler in
    wireNetworkDetailPane covers them unchanged; only the markup moved.
  • Pre-existing, untouched, noticed in passing: copyNetworkCurl and cloneCapturedRequest
    both do if (!r.ok) return; with no toast, so a failing /curl fetch is completely silent to
    the user. Out of scope here — worth its own fix.

Munif and others added 3 commits August 25, 2026 11:49
The Network detail head had grown three stacked strips above the tabs — a
facts row, an actions row, and the tabs themselves — pushing the request and
response panes well down the viewport. Each strip also duplicated something
already on screen: the facts repeated what the compare panes' "General" groups
showed, and the actions row spent a full row on buttons that are used
occasionally, not per-capture.

Consolidate onto the Summary tab and a kebab menu:

- Move the facts strip (time, duration, content type, correlation, mock rule,
  vs-original) out of the head and into Summary, where the mock rule keeps its
  link into Mocks via a new `mockRuleLink` kv-grid row type.
- Drop the "General" group from both compare panes. Everything it held now
  lives in Summary, so the tab is just headers and body.
- Give the failure branch's error string its own `response.error` Summary row
  instead of parenthesising it into `response.status`; it was previously only
  reachable through the General group that just went away.
- Replace the actions row with a kebab (⋮) menu beside the expand button.
  Opt-in per pane via `actionsMenu`, so WebSockets/Push/Crashes — two or three
  actions each — keep their flat rows. Items carry the same
  `data-detail-action` ids, so the existing delegated handlers are unchanged.
  Closes on pick, outside click, and Escape.
- Order Summary first among the tabs. Default selection is still
  Request & response.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The spec's Network entry still described a "detail action row (Clone to
composer, cURL, fetch, JSON, Related events)" that predates the current
actions/tabs split, and nothing documented the detail pane's anatomy at all —
so the previous commit's rearrangement had no spec to disagree with.

Add §4a covering the shared head (badge/title/status/expand), the two variants
of its middle band (Network's kebab menu vs. the other panes' flat actions
row), Network's tab order and why Summary leads while Request & response stays
the default selection, the absent "General" group, group collapse defaults,
and Simple-mode hiding.

Also correct three stale claims while in here: §5 named `.list`/`.detail-pane`
(now `.list-pane`/`.detail-pane-v2` inside `.split-shell`), §6's Network
toolbar list omitted the service dropdown and More-filters disclosure, and the
new §4a records that Timeline hand-rolls its own head instead of using
`detailHeadHtml` — logged as an open item rather than left as a silent drift.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The box borders didn't line up: the 🔍 and 🔒 emoji are double-width, so the
lines carrying them ran two columns past the frame while every other row sat
short of it. Dropped both emoji and repadded every line to a uniform 62-column
interior, verified by measuring East Asian width rather than counting
characters.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@maksudur03 maksudur03 self-assigned this Aug 25, 2026
@Shakibuzzaman3104
Shakibuzzaman3104 merged commit 019851b into release/1.3.2 Aug 25, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants