Repository navigation
Feature/dashboard UI refactor - #35
Merged
Merged
Conversation
The Network detail head had grown three stacked strips above the tabs — a facts row, an actions row, and the tabs themselves — pushing the request and response panes well down the viewport. Each strip also duplicated something already on screen: the facts repeated what the compare panes' "General" groups showed, and the actions row spent a full row on buttons that are used occasionally, not per-capture. Consolidate onto the Summary tab and a kebab menu: - Move the facts strip (time, duration, content type, correlation, mock rule, vs-original) out of the head and into Summary, where the mock rule keeps its link into Mocks via a new `mockRuleLink` kv-grid row type. - Drop the "General" group from both compare panes. Everything it held now lives in Summary, so the tab is just headers and body. - Give the failure branch's error string its own `response.error` Summary row instead of parenthesising it into `response.status`; it was previously only reachable through the General group that just went away. - Replace the actions row with a kebab (⋮) menu beside the expand button. Opt-in per pane via `actionsMenu`, so WebSockets/Push/Crashes — two or three actions each — keep their flat rows. Items carry the same `data-detail-action` ids, so the existing delegated handlers are unchanged. Closes on pick, outside click, and Escape. - Order Summary first among the tabs. Default selection is still Request & response. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The spec's Network entry still described a "detail action row (Clone to composer, cURL, fetch, JSON, Related events)" that predates the current actions/tabs split, and nothing documented the detail pane's anatomy at all — so the previous commit's rearrangement had no spec to disagree with. Add §4a covering the shared head (badge/title/status/expand), the two variants of its middle band (Network's kebab menu vs. the other panes' flat actions row), Network's tab order and why Summary leads while Request & response stays the default selection, the absent "General" group, group collapse defaults, and Simple-mode hiding. Also correct three stale claims while in here: §5 named `.list`/`.detail-pane` (now `.list-pane`/`.detail-pane-v2` inside `.split-shell`), §6's Network toolbar list omitted the service dropdown and More-filters disclosure, and the new §4a records that Timeline hand-rolls its own head instead of using `detailHeadHtml` — logged as an open item rather than left as a silent drift. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The box borders didn't line up: the 🔍 and 🔒 emoji are double-width, so the lines carrying them ran two columns past the frame while every other row sat short of it. Dropped both emoji and repadded every line to a uniform 62-column interior, verified by measuring East Asian width rather than counting characters. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Declutters the Network detail pane. Five changes:
everything it showed. Headers stay collapsed, payload/body expanded (already the default).
response.error) — General was its only home before,and General is gone.
opens the list.
Web assets only (
dashboard.js,dashboard.css,index.html); no Kotlin, no API surface, nocapture-path code.
Verification
Which
./gradlewcommands did you run, and what did they confirm? (SeeCONTRIBUTING.md for the standard set.)
./gradlew :sdk:server-ktor:test— passing (includesDashboardAssetsTest, the CSP guardthat fails the build on inline scripts/handlers in these assets)
./gradlew :sdk:server-ktor:ktlintCheck :sdk:server-ktor:detekt apiCheck— clean./gradlew ktlintCheck detekt(repo-wide) — fails on two pre-existing issues outside thisdiff, both in files this PR does not touch (and which Kotlin lint could not be affected by,
since this diff is
.js/.css/.htmlonly):-
samples/foundation-app/.../MainActivity.kt:335,504— 4 ktlint violations-
sdk/server-api/.../LocalServerEngine.kt:205— detektTooManyFunctionsonSessionAuthority(13/11)./gradlew apiCheck— clean; no public API change, so noapiDumpneededChecklist
RedactionEnginefirst — this only rearranges fields the pane already received anddisplayed; the redaction footnote is unchanged
docs/DESIGN_SPEC.md§4 describes the detail-pane layout and now trails thecode on the facts strip and actions row. Happy to update it here or in a follow-up, reviewer's
call.
Anything reviewers should look at closely
detailHeadHtmlgained anactionsMenuflag that onlyrenderNetworkDetailpasses; WebSockets/Push/Crashes carry two or three actions each and keeptheir flat rows, where a menu would only add a click. One line each to flip them if you'd rather
the chrome be uniform.
.detail-menu-panelisposition: fixed, placed bypositionDetailMenuPanel(). It has tobe —
.detail-pane-v2isoverflow: hidden, so an absolutely positioned popup clips at the paneedge. Same trade the toolbar
.drop-paneldropdowns already make.data-detail-actionids, so the existing delegated click handler inwireNetworkDetailPanecovers them unchanged; only the markup moved.copyNetworkCurlandcloneCapturedRequestboth do
if (!r.ok) return;with no toast, so a failing/curlfetch is completely silent tothe user. Out of scope here — worth its own fix.