Repository navigation
refactor(dashboard): declutter the Network detail pane - #34
Closed
maksudur03 wants to merge 1 commit into
Closed
maksudur03 wants to merge 1 commit into
maksudur03 wants to merge 1 commit into
Conversation
The Network detail head had grown three stacked strips above the tabs — a facts row, an actions row, and the tabs themselves — pushing the request and response panes well down the viewport. Each strip also duplicated something already on screen: the facts repeated what the compare panes' "General" groups showed, and the actions row spent a full row on buttons that are used occasionally, not per-capture. Consolidate onto the Summary tab and a kebab menu: - Move the facts strip (time, duration, content type, correlation, mock rule, vs-original) out of the head and into Summary, where the mock rule keeps its link into Mocks via a new `mockRuleLink` kv-grid row type. - Drop the "General" group from both compare panes. Everything it held now lives in Summary, so the tab is just headers and body. - Give the failure branch's error string its own `response.error` Summary row instead of parenthesising it into `response.status`; it was previously only reachable through the General group that just went away. - Replace the actions row with a kebab (⋮) menu beside the expand button. Opt-in per pane via `actionsMenu`, so WebSockets/Push/Crashes — two or three actions each — keep their flat rows. Items carry the same `data-detail-action` ids, so the existing delegated handlers are unchanged. Closes on pick, outside click, and Escape. - Order Summary first among the tabs. Default selection is still Request & response. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Declutters the Network detail pane. Five changes:
rule (still links into Mocks), vs-original.
everything it showed. Headers stay collapsed, payload/body expanded (already the default).
response.error) — General was its only home before,and General is gone.
opens the list.
Web assets only (
dashboard.js,dashboard.css,index.html); no Kotlin, no API surface, nocapture-path code.
Verification
./gradlew :sdk:server-ktor:test— passing (includesDashboardAssetsTest, the CSP guardthat fails the build on inline scripts/handlers in these assets)
./gradlew :sdk:server-ktor:ktlintCheck :sdk:server-ktor:detekt apiCheck— clean./gradlew ktlintCheck detekt(repo-wide) — fails on two pre-existing issues outside thisdiff, both in files this PR does not touch (and which Kotlin lint could not be affected by,
since this diff is
.js/.css/.htmlonly):-
samples/foundation-app/.../MainActivity.kt:335,504— 4 ktlint violations-
sdk/server-api/.../LocalServerEngine.kt:205— detektTooManyFunctionsonSessionAuthority(13/11)./gradlew apiCheck— clean; no public API change, so noapiDumpneededBeyond Gradle, every path was exercised by driving the real
index.html/dashboard.css/dashboard.jsin a browser against a stub server:BASErow tag and the Diff tab appear and disappear), Resend, Clone to composer (lands on Composer with
the curl prefilled), Mock this response (dialog prefilled from the capture), Unmock, cURL and
fetch (correct text on the clipboard). Each also dismissed the menu.
vs originalpresent), and a no-response failure (
response.errorpresent).pin/fetchvia the existing.detail-action-hide-simplerule.Checklist
RedactionEnginefirst — this only rearranges fields the pane already received anddisplayed; the redaction footnote is unchanged
docs/DESIGN_SPEC.md§4a specifies the detail-pane anatomy (shared head,kebab-vs-row variants, tab order, group defaults, Simple-mode hiding). §5 and §6 corrected
where they had gone stale.
Anything reviewers should look at closely
detailHeadHtmlgained anactionsMenuflag that onlyrenderNetworkDetailpasses; WebSockets/Push/Crashes carry two or three actions each and keeptheir flat rows, where a menu would only add a click. One line each to flip them if you'd rather
the chrome be uniform.
.detail-menu-panelisposition: fixed, placed bypositionDetailMenuPanel(). It has tobe —
.detail-pane-v2isoverflow: hidden, so an absolutely positioned popup clips at the paneedge. Same trade the toolbar
.drop-paneldropdowns already make.data-detail-actionids, so the existing delegated click handler inwireNetworkDetailPanecovers them unchanged; only the markup moved.copyNetworkCurlandcloneCapturedRequestboth do
if (!r.ok) return;with no toast, so a failing/curlfetch is completely silent tothe user. Out of scope here — worth its own fix.
🤖 Generated with Claude Code