Skip to content

fix: verify each protected variant with its own task - #30

Merged
maksudur03 merged 1 commit into
release/1.3.0from
fix/per-variant-protected-verifier
Aug 24, 2026
Merged

maksudur03 merged 1 commit into
release/1.3.0from
fix/per-variant-protected-verifier

Conversation

@Shakibuzzaman3104

Copy link
Copy Markdown
Collaborator
  • One verifyDevConsoleProtectedArtifacts per protected variant, holding only that variant's runtime classpath and packaged scan
  • Each variant's assemble/bundle depends only on its own verifier, so building one flavor's release no longer builds every other flavor's
  • verifyDevConsoleProtectedArtifacts is now an aggregate over all of them; check, CI and existing release scripts keep working unchanged
  • Packaged-artifact scans are keyed by variant name instead of collected into one list
  • Functional test asserts no other flavor's tasks reach the task graph
  • README, CHANGELOG and docs cover the flavored-project case and upgrade

What

One or two sentences on what changed and why (the "why" matters more than the "what" — the diff
already shows the what).

Verification

Which ./gradlew commands did you run, and what did they confirm? (See
CONTRIBUTING.md for the standard set.)

  • ./gradlew testDebugUnitTest — passing
  • ./gradlew ktlintCheck detekt — clean (or new detekt findings are justified, not baselined away)
  • ./gradlew apiCheck — clean, or apiDump is included in this diff because the public API changed
  • If this touches a debug/release or protected-variant boundary: sample assemble/verify commands
    run for the affected sample(s) (:samples:<name>:assembleRelease :samples:<name>:verifyDevConsoleProtectedArtifacts)

Checklist

  • Capture-path code (network/socket/push) never throws into the host app
  • No new sensitive data is captured, logged, or exported without going through
    RedactionEngine first
  • Docs updated if behavior, an API, or a config field changed
    (see docs/README.md for the index)
  • This PR is scoped to one logical change

Anything reviewers should look at closely

Optional — call out anything you're unsure about, a tradeoff you made, or a spot you want a second
look at.

- One verify<Variant>DevConsoleProtectedArtifacts per protected variant,
  holding only that variant's runtime classpath and packaged scan
- Each variant's assemble/bundle depends only on its own verifier, so
  building one flavor's release no longer builds every other flavor's
- verifyDevConsoleProtectedArtifacts is now an aggregate over all of them;
  check, CI and existing release scripts keep working unchanged
- Packaged-artifact scans are keyed by variant name instead of collected
  into one list
- Functional test asserts no other flavor's tasks reach the task graph
- README, CHANGELOG and docs cover the flavored-project case and upgrade
@maksudur03
maksudur03 merged commit e2c2400 into release/1.3.0 Aug 24, 2026
1 check failed
@Shakibuzzaman3104 Shakibuzzaman3104 mentioned this pull request Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants