Repository navigation
Fix/fix background coonnectivity - #28
Merged
Merged
Conversation
added 2 commits
August 24, 2026 16:52
- prefer port 8080 and fall back when occupied externally - restart the SDK-owned server before rebinding - bind immediately and hydrate persisted timeline asynchronously - request required LAN permissions before server startup - keep notification permission optional - default browser access to open mode with same-origin protection - synchronize notification stop actions with SDK UI state - keep no-op release artifacts permission-free - add tests and documentation for server lifecycle behavior
# Conflicts: # sdk/server-ktor/src/main/resources/devconsole-web/dashboard.js
nur-shuvo
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes Android DevConsole server startup predictable and responsive by binding before timeline hydration, preferring port 8080, and restarting SDK-owned listeners safely. It also moves LAN permission handling into the SDK UI, keeps notifications optional, defaults browser access to open mode with same-origin protection, and keeps no-op release artifacts permission-free.
Verification
Relevant unit tests — passing
ktlintCheckanddetekt— cleanapiCheck— cleanDebug/release and protected-variant boundaries verified
The release builds also ran and passed their protected-artifact verification tasks. APK manifest inspection confirmed that release/no-op builds do not contain DevConsole LAN, Nearby Devices, notification, or foreground-service permissions.
git diff --check— cleanChecklist
RedactionEnginefirstAnything reviewers should look at closely
Please review the asynchronous timeline initialization and buffering path, particularly events captured between socket binding and Room session creation.
Port replacement intentionally applies only to a server owned by the current SDK runtime. If another process owns port 8080, the SDK falls back through ports 8081–8099 rather than attempting to terminate that process.
The LAN permission policy distinguishes
NEARBY_WIFI_DEVICESfrom the newerACCESS_LOCAL_NETWORKbehavior. Notification permission is deliberately optional and is requested only after the server is running.