Skip to content

Improve/improve network searching - #15

Merged
nur-shuvo merged 21 commits into
mainfrom
improve/improve-network-searching
Aug 18, 2026
Merged

nur-shuvo merged 21 commits into
mainfrom
improve/improve-network-searching

Conversation

@Shakibuzzaman3104

Copy link
Copy Markdown
Collaborator

What

Moves the library artifacts from Maven Central to JitPack, because maintaining GPG keys, namespace
verification, and Central's irreversible-release ceremony bought nothing over a channel that builds
straight from a tag. The Gradle plugin stays on the Plugin Portal — the plugins { } DSL can't
resolve a marker from JitPack — and its variant-policy check now matches both the new and old groups
so unmigrated hosts keep their release-build protection.

Also on this branch: the capture detail search gains scoping, hit stepping, and a full-screen body
reader.

Verification

  • ./gradlew testDebugUnitTest — passing. Also ran ./gradlew test, which the standard set
    lists separately and which is what actually covers the Kotlin/JVM modules; :sdk:api tests
    only run under test, and that's where a real failure was hiding.
  • ./gradlew ktlintCheck detekt — clean. detekt findings were fixed, not baselined (details
    below).
  • ./gradlew apiCheck — clean; apiDump is in the diff. The .api delta is only
    Compose-generated ComposableSingletons lambda accessors — no public surface change.
  • Touches the protected-variant boundary (the plugin's group matching changed), so all three
    samples ran assembleDebug assembleRelease verifyDevConsoleProtectedArtifacts — all pass.

Also: ./gradlew -p gradle-plugin test (full functional suite) and ./gradlew publishToMavenLocal
across all 34 modules — the latter is now the primary release gate since signing was removed from
the publication shape.

Checklist

  • Capture-path code never throws into the host app — capture paths untouched by the distribution
    change
  • No new sensitive data captured, logged, or exported — no new capture or export surface
  • Docs updated — MAVEN_PUBLISHING.md → PUBLISHING.md (rewritten), README, all three
    getting-started guides, MIGRATION.md (new "Upgrading from 1.2.1"),
    BUILD_VARIANTS_AND_PRODUCTION_SAFETY.md, RELEASE_CHECKLIST.md, REMOTE_CONFIG.md,
    docs/README.md, CHANGELOG
  • Not scoped to one logical change — deliberately. It carries the distribution switch
    (e69c748) and the search feature (26dd74b). Splitting was considered and declined; the
    commits are cleanly separated if a reviewer wants to read them independently.

Anything reviewers should look at closely

1. The group matching in DevConsoleVariantPolicyPlugin.kt is the risky part. The Central group
was hardcoded in four places — auto-wire coordinate, isDevConsole, the declared-dependency
violation check, and the FULL_RUNTIME_COORDINATE regex for the transitive walk. Miss one and the
plugin silently stops catching the full runtime in a release build, which is its whole purpose. All
four now accept both groups, and there are new functional tests for each. Those tests were
mutation-checked
: my first version passed even with legacy-group support removed, because the
transitive-regex path was satisfying the assertion instead of the declared-dependency path.
Tightened to assert the declared form specifically, then re-confirmed it fails when the matching
breaks.

2. JitPack versions carry the v prefix, and this was a shipping bug. Verified against the live
registry: v1.2.1 resolves, bare 1.2.1 404s — JitPack does not strip the prefix. The plugin was
auto-wiring the bare form, so every zero-config consumer would have hit an unresolvable
dependency
. Nothing in the local build could catch this; only querying JitPack did. Note the
deliberate asymmetry: plugin version is bare 1.2.2 (Portal), library coordinates are v1.2.2
(JitPack).

3. Two Critical issues came from an earlier merge, not from this work. ebd34af merged main's
AUTO binding default into the branch's LAN work. Git conflicted on StartRequest.kt (resolved
correctly) but cleanly auto-merged DevConsoleContractTest.kt, where each side had added a
different test — leaving two tests asserting opposite defaults and a red build. startBrowser's
KDoc was stranded on the wrong default too. Worth knowing main has the same KDoc drift
independently (it says "loopback" while the code says AUTO), so this fix corrects both.

4. The detekt config exemption is a judgment call. 11 of 16 findings were @Composable hitting
LongParameterList/LongMethod — a composable's parameters are its API, and a parameter object
costs recomposition stability. Those are exempted in a new config/detekt/detekt.yml; the
complexity rules stay fully on, which is what forced the genuine refactor of
InspectorObserveDetailScreen (cyclomatic complexity 38 → under 15). If you'd rather those 11 were
refactored instead, the config is one file to delete. Note the file still carries pre-existing
suppressions from before this branch, including one on resolveDetailSection.

5. CI now publishes the plugin on a v* tag, automatically. Originally gated behind a protected
environment; removed on the reasoning that pushing a tag is the release decision. Guards kept:
tag-vs-declared-version (a mismatch fails rather than publishing an uncorrectable coordinate) and
the plugin test suite. setup-gradle is SHA-pinned in that workflow specifically because it runs
beside the Portal credentials — the rest of the repo still uses tags.

# Conflicts:
#	README.md
#	docs/LAN_PERMISSION_AND_TROUBLESHOOTING.md
#	docs/THREAT_MODEL.md
#	sdk/api/src/main/kotlin/io/devconsole/api/FocusedPolicies.kt
#	sdk/api/src/main/kotlin/io/devconsole/api/StartRequest.kt
#	sdk/api/src/test/kotlin/io/devconsole/api/FocusedConfigurationTest.kt
#	sdk/full/src/main/kotlin/io/devconsole/PlatformFacadeProvider.kt
#	sdk/full/src/test/kotlin/io/devconsole/FullFacadeTest.kt
#	sdk/full/src/test/kotlin/io/devconsole/PlatformFacadeProviderMoreScreenBindingTest.kt
Library artifacts move to com.github.devconsole-android.DevConsole; the Gradle
plugin stays on the Plugin Portal and now matches both groups.
Adds a search-options sheet (sections, names/values), a hit counter with
stepping, and a full-screen body viewer; drops the one-off update.py script.
Formatting only; the .api diff is Compose-generated ComposableSingletons
lambda accessors, no public API surface change.
Exempts @composable from LongParameterList/LongMethod (Compose cannot satisfy
either without hurting the code); the complexity rules stay on and the
InspectorObserveDetailScreen/resolveNetworkDetailSection hot spots are split up.
A stale LAN assertion from before the 1.2.1 merge failed :sdk:api:test, and
startBrowser's KDoc claimed a binding default the code has not used since 1.2.1.
Drops the test-only searchInspectorSections in favour of a helper the screen
actually calls, and narrows a file-wide suppression to a @Preview exemption.
The Portal is as irreversible as Central was, so the tag trigger is gated on a
protected environment rather than publishing outright; guards tag vs version.
Pushing a v* tag is the release decision, so the approval gate was redundant.
setup-gradle is pinned to a SHA since this job runs beside the Portal secrets.
Verified against the live registry: v1.2.1 resolves, 1.2.1 404s. The plugin was
auto-wiring the bare form, so every zero-config consumer would have failed.
A bare <version> reads as 1.2.2, which 404s; the tag prefix is part of the
coordinate. The Portal-hosted plugin keeps its bare version.
@nur-shuvo
nur-shuvo merged commit f245898 into main Aug 18, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants