Repository navigation
Improve/improve network searching - #15
Merged
Merged
Conversation
# Conflicts: # README.md # docs/LAN_PERMISSION_AND_TROUBLESHOOTING.md # docs/THREAT_MODEL.md # sdk/api/src/main/kotlin/io/devconsole/api/FocusedPolicies.kt # sdk/api/src/main/kotlin/io/devconsole/api/StartRequest.kt # sdk/api/src/test/kotlin/io/devconsole/api/FocusedConfigurationTest.kt # sdk/full/src/main/kotlin/io/devconsole/PlatformFacadeProvider.kt # sdk/full/src/test/kotlin/io/devconsole/FullFacadeTest.kt # sdk/full/src/test/kotlin/io/devconsole/PlatformFacadeProviderMoreScreenBindingTest.kt
Library artifacts move to com.github.devconsole-android.DevConsole; the Gradle plugin stays on the Plugin Portal and now matches both groups.
Adds a search-options sheet (sections, names/values), a hit counter with stepping, and a full-screen body viewer; drops the one-off update.py script.
Formatting only; the .api diff is Compose-generated ComposableSingletons lambda accessors, no public API surface change.
Exempts @composable from LongParameterList/LongMethod (Compose cannot satisfy either without hurting the code); the complexity rules stay on and the InspectorObserveDetailScreen/resolveNetworkDetailSection hot spots are split up.
A stale LAN assertion from before the 1.2.1 merge failed :sdk:api:test, and startBrowser's KDoc claimed a binding default the code has not used since 1.2.1.
Drops the test-only searchInspectorSections in favour of a helper the screen actually calls, and narrows a file-wide suppression to a @Preview exemption.
The Portal is as irreversible as Central was, so the tag trigger is gated on a protected environment rather than publishing outright; guards tag vs version.
Pushing a v* tag is the release decision, so the approval gate was redundant. setup-gradle is pinned to a SHA since this job runs beside the Portal secrets.
Verified against the live registry: v1.2.1 resolves, 1.2.1 404s. The plugin was auto-wiring the bare form, so every zero-config consumer would have failed.
A bare <version> reads as 1.2.2, which 404s; the tag prefix is part of the coordinate. The Portal-hosted plugin keeps its bare version.
nur-shuvo
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the library artifacts from Maven Central to JitPack, because maintaining GPG keys, namespace
verification, and Central's irreversible-release ceremony bought nothing over a channel that builds
straight from a tag. The Gradle plugin stays on the Plugin Portal — the
plugins { }DSL can'tresolve a marker from JitPack — and its variant-policy check now matches both the new and old groups
so unmigrated hosts keep their release-build protection.
Also on this branch: the capture detail search gains scoping, hit stepping, and a full-screen body
reader.
Verification
./gradlew testDebugUnitTest— passing. Also ran./gradlew test, which the standard setlists separately and which is what actually covers the Kotlin/JVM modules;
:sdk:apitestsonly run under
test, and that's where a real failure was hiding../gradlew ktlintCheck detekt— clean. detekt findings were fixed, not baselined (detailsbelow).
./gradlew apiCheck— clean;apiDumpis in the diff. The.apidelta is onlyCompose-generated
ComposableSingletonslambda accessors — no public surface change.samples ran
assembleDebug assembleRelease verifyDevConsoleProtectedArtifacts— all pass.Also:
./gradlew -p gradle-plugin test(full functional suite) and./gradlew publishToMavenLocalacross all 34 modules — the latter is now the primary release gate since signing was removed from
the publication shape.
Checklist
change
MAVEN_PUBLISHING.md→PUBLISHING.md(rewritten), README, all threegetting-started guides,
MIGRATION.md(new "Upgrading from 1.2.1"),BUILD_VARIANTS_AND_PRODUCTION_SAFETY.md,RELEASE_CHECKLIST.md,REMOTE_CONFIG.md,docs/README.md, CHANGELOG(
e69c748) and the search feature (26dd74b). Splitting was considered and declined; thecommits are cleanly separated if a reviewer wants to read them independently.
Anything reviewers should look at closely
1. The group matching in
DevConsoleVariantPolicyPlugin.ktis the risky part. The Central groupwas hardcoded in four places — auto-wire coordinate,
isDevConsole, the declared-dependencyviolation check, and the
FULL_RUNTIME_COORDINATEregex for the transitive walk. Miss one and theplugin silently stops catching the full runtime in a release build, which is its whole purpose. All
four now accept both groups, and there are new functional tests for each. Those tests were
mutation-checked: my first version passed even with legacy-group support removed, because the
transitive-regex path was satisfying the assertion instead of the declared-dependency path.
Tightened to assert the declared form specifically, then re-confirmed it fails when the matching
breaks.
2. JitPack versions carry the
vprefix, and this was a shipping bug. Verified against the liveregistry:
v1.2.1resolves, bare1.2.1404s — JitPack does not strip the prefix. The plugin wasauto-wiring the bare form, so every zero-config consumer would have hit an unresolvable
dependency. Nothing in the local build could catch this; only querying JitPack did. Note the
deliberate asymmetry: plugin version is bare
1.2.2(Portal), library coordinates arev1.2.2(JitPack).
3. Two Critical issues came from an earlier merge, not from this work.
ebd34afmerged main'sAUTObinding default into the branch'sLANwork. Git conflicted onStartRequest.kt(resolvedcorrectly) but cleanly auto-merged
DevConsoleContractTest.kt, where each side had added adifferent test — leaving two tests asserting opposite defaults and a red build.
startBrowser'sKDoc was stranded on the wrong default too. Worth knowing
mainhas the same KDoc driftindependently (it says "loopback" while the code says
AUTO), so this fix corrects both.4. The detekt config exemption is a judgment call. 11 of 16 findings were
@ComposablehittingLongParameterList/LongMethod— a composable's parameters are its API, and a parameter objectcosts recomposition stability. Those are exempted in a new
config/detekt/detekt.yml; thecomplexity rules stay fully on, which is what forced the genuine refactor of
InspectorObserveDetailScreen(cyclomatic complexity 38 → under 15). If you'd rather those 11 wererefactored instead, the config is one file to delete. Note the file still carries pre-existing
suppressions from before this branch, including one on
resolveDetailSection.5. CI now publishes the plugin on a
v*tag, automatically. Originally gated behind a protectedenvironment; removed on the reasoning that pushing a tag is the release decision. Guards kept:
tag-vs-declared-version (a mismatch fails rather than publishing an uncorrectable coordinate) and
the plugin test suite.
setup-gradleis SHA-pinned in that workflow specifically because it runsbeside the Portal credentials — the rest of the repo still uses tags.