You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Reject linked desired-state documents in complete package validation #536
The complete package validator can report success while an onboarding desired-state document is linked outside the package and its contents were never fully validated. This lets unusable or non-contained onboarding configuration pass the gate used to ship the marketplace.
At current main 685d06b7398169cfd25245f6f55916538f4f41c5, a complete healthy package passes. Replacing its canonical desired-state file with a link to malformed configuration also passes and emits no desired-state validation result. The identical malformed configuration as a regular packaged file is rejected. The shipped regular document remains healthy.
The existing #379 delivery protects the digest writer. This is the separate package-validator consumer's discovery and containment boundary.
Proposed direction
Observe every desired-state document and resource-directory boundary before reporting package success. Refuse linked or nonregular documents and linked resource parents while retaining supported regular packaged resources.
Acceptance
Preserve complete-package RED/GREEN controls for the canonical document, additional documents and linked resource parents, alongside a healthy regular package.
Refuse unsupported filesystem boundaries before accepting or silently omitting their contents; incomplete discovery remains a failure.
Keep the current marketplace, existing manifest and package-boundary regressions green.
Deliver through native current-head CI, substantive review, protected merge and an exercised merged package gate.
Delivered by PR #537, merged at 2026-10-06T05:13:16Z with verified signed main commit 149b300.
Production-gate RED/GREEN and healthy controls cover 22 complete-entrypoint cases; all 433 existing manifest cases passed. The independently discovered canonical inventory omission was repaired and reviewed. At the evaluated PR head, all 44 successful checks and two expected skips were settled, the required aggregate check was green, substantive current-head review was clean and no findings/threads remained.
Postmerge user readback: native main run 37417456266, Validate manifests job 112119118941, checked out the exact landed commit and executed the actual complete package command successfully. Its complete log confirms validation of the canonical desired-state document. This observes the real merged package, separately from the refusal fixtures. No remaining delivery blocker.
Activity
chore: agent-claim #536 nonce=e66e6db9b8a122d35a8ab6725baba081
chore: agent-claim #536 nonce=96476c3e4af4cc357923dae4d4c49394
devantler commentedon Oct 6, 2026
Delivered by PR #537, merged at 2026-10-06T05:13:16Z with verified signed main commit 149b300.
Production-gate RED/GREEN and healthy controls cover 22 complete-entrypoint cases; all 433 existing manifest cases passed. The independently discovered canonical inventory omission was repaired and reviewed. At the evaluated PR head, all 44 successful checks and two expected skips were settled, the required aggregate check was green, substantive current-head review was clean and no findings/threads remained.
Postmerge user readback: native main run 37417456266, Validate manifests job 112119118941, checked out the exact landed commit and executed the actual complete package command successfully. Its complete log confirms validation of the canonical desired-state document. This observes the real merged package, separately from the refusal fixtures. No remaining delivery blocker.