Skip to content

fix(ci): stop the to-do scan filing an issue from its own comment - #304

Merged
devantler merged 2 commits into
mainfrom
claude/ci-todo-self-match-251
Sep 26, 2026
Merged

devantler merged 2 commits into
mainfrom
claude/ci-todo-self-match-251

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

The shared scan that turns code comments marked as open work into issues read one of its own explanatory comments as such a marker, and filed an issue with a garbled title. Its neighbouring note also claimed the scan only matches the marker in capitals, which is how the mistake slipped in.

What

Both explanatory comments now spell the word with a hyphen, which the scan does not match, and the note states the real rule. When this lands, the scan closes the mistaken issue by itself.

Fixes #251

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 36 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 1d8e3f74-4645-41cc-b70c-7861b64a3fa2

📥 Commits

Reviewing files that changed from the base of the PR and between 55e1ead and 5e9931a.

📒 Files selected for processing (2)
  • .github/workflows/scan-for-todo-comments.yaml
  • actions/create-issues-from-todos/README.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Code Coverage Overview

Languages: Go, C#

Go / code-coverage/test

The overall line coverage in commit 5e9931a in the claude/ci-todo-self-... branch remains at 50%, unchanged from commit 55e1ead in the main branch.

C# / code-coverage/dotnet

The overall line coverage in commit 5e9931a in the claude/ci-todo-self-... branch remains at 100%, unchanged from commit 55e1ead in the main branch.


Updated September 26, 2026 22:48 UTC

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

✅MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 0.46s
✅ GO revive 2 0 0 7.83s
✅ REPOSITORY betterleaks yes no no 0.88s
✅ REPOSITORY checkov yes no no 14.24s
✅ REPOSITORY git_diff yes no no 0.03s
✅ REPOSITORY osv-scanner yes no no 0.69s
✅ REPOSITORY secretlint yes no no 0.8s
✅ REPOSITORY syft yes no no 1.12s
✅ REPOSITORY trivy yes no no 9.22s
✅ REPOSITORY trivy-sbom yes no no 0.07s
✅ REPOSITORY trufflehog yes no no 3.5s

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@10.1.0 --custom-flavor-setup --custom-flavor-linters COPYPASTE_JSCPD,GO_REVIVE,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_BETTERLEAKS,REPOSITORY_OSV_SCANNER,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ebfcce5f32

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/scan-for-todo-comments.yaml
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T22:38:08.098492Z 5e9931a Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

…phenate it

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 5e9931a64a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness at 5e9931a6

  • Tested: all 163 checks pass (104 skipped by path filters). No unresolved threads. The branch is CLEAN.
  • Reviewed: Codex found no major issues at 5e9931a64a. Its one P2 at ebfcce5 (the action README still recommended lowercase) is fixed in this head. CodeRabbit was rate-limited at both heads.
  • Tried as a user: production already ran the scanner on this exact file. On 2026-09-25 it filed scan above), but the runner re-reads the composite's action.yaml from disk to #251 from the comment line reading "the todo scan above". It filed nothing from the hyphenated "todo-comment scan" two dozen lines above it. Both comments now use the hyphenated form, which that same production run showed the scanner skips. With INPUT_CLOSE_ISSUES: "true", the first scan on main after merge closes scan above), but the runner re-reads the composite's action.yaml from disk to #251. I will confirm that closure after merge. Nothing else here can run: the change is comment and README text only.

@devantler
devantler marked this pull request as ready for review September 26, 2026 22:47
@devantler
devantler merged commit 411454a into main Sep 26, 2026
500 checks passed
@devantler
devantler deleted the claude/ci-todo-self-match-251 branch September 26, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scan above), but the runner re-reads the composite's action.yaml from disk to

1 participant