Conversation
Signed-off-by: Lukas Geiger <lukas@um-bruch.org>
|
Welcome! 👋 Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing! |
added 2 commits
October 2, 2026 03:54
Signed-off-by: Lukas Geiger <lukas@um-bruch.org>
Signed-off-by: Lukas Geiger <lukas@um-bruch.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An interrupted editor save could truncate an existing file before returning an error. Invalid UTF-8 could also escape the save boundary after the target was opened. Both failures were reproduced on unchanged
mainat4116f36.EditorTabnow encodes the full buffer as strict UTF-8 with native newlines before opening the target, then writes through QtQSaveFilewith direct-write fallback disabled. It checks open, byte count and final commit; on failure it cancels the temporary write, reports the error and keeps the document dirty. Existing SaveAs, Close and Run guards remain in place.This branch also repairs CI issues exposed by the full suite: test jobs install Pillow; platform smoke tests use the selected interpreter and named debug argument and expose the terminal process error signal; a
tomlifallback preserves metadata parsing on Python 3.10.Validation:
56bf06b: all 13 GitHub Actions jobs passed, covering lint and Windows/Linux/macOS on Python 3.10–3.13.4116f36full suite passed 346 tests with 1 skip. Candidated528a85passed 353 with 1 skip. Current HEAD is validated by CI; no separate final-head local full-suite run was started..gitremain intact. The privateconfig/settings.jsonwas excluded from the isolated snapshot.Version remains 0.3.5. No executable was built and no release was made. This remains Draft PR #2; merge still requires the separate review gate for a different model class.