Skip to content

finances/stmt.ts added with public mobile statement support#11

Merged
denversc merged 14 commits into
mainfrom
stmt
Jun 16, 2026
Merged

finances/stmt.ts added with public mobile statement support#11
denversc merged 14 commits into
mainfrom
stmt

Conversation

@denversc

Copy link
Copy Markdown
Owner

No description provided.

@denversc denversc merged commit 12e4f20 into main Jun 16, 2026
3 checks passed
@denversc denversc deleted the stmt branch June 16, 2026 07:30

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new command-line utility stmt in the finances directory, along with adding @formkit/tempo as a dependency. The utility parses Public Mobile PDF statements to extract metadata and offers commands to print, identify, parse, and rename files. The review feedback highlights several opportunities to make the tool more robust, such as deduplicating input file paths in the rename command to prevent runtime crashes, avoiding redundant file renames, strengthening PDF identification and date validation, and making the extraction of the total amount paid less fragile.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread finances/stmt.ts
Comment thread finances/stmt.ts
Comment thread finances/stmt.ts
Comment thread finances/stmt.ts
Comment thread finances/stmt.ts
Comment thread finances/stmt.ts
dconeybe pushed a commit that referenced this pull request Jun 17, 2026
…is specified multiple times.

This addresses the following code review feedback: If duplicate file paths are passed to the rename command (e.g., via wildcards or manual duplication), the command will attempt to rename the same file twice. The second attempt will fail with an ENOENT error because the source file has already been renamed/moved. Deduplicating the file paths before processing prevents this crash.

#11 (comment)
dconeybe pushed a commit that referenced this pull request Jun 17, 2026
… command

This addresses the following code review feedback:

Calling `fs.rename` when the source and destination paths are identical is redundant and can cause unnecessary file system operations or errors. Additionally, `path.join` natively handles cases where `dir` is `.` or empty, making the conditional check redundant. Resolving and comparing the paths beforehand avoids this.

#11 (comment)
dconeybe pushed a commit that referenced this pull request Jun 17, 2026
…ing PDF parsing

This addresses the following code review feedback:

In JavaScript/TypeScript, parsing an invalid date string may return an invalid `Date` object (where `isNaN(date.getTime())` is true) instead of throwing an error. Adding an explicit check ensures robust error handling.

#11 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant