GEM: Excelアップロードで整数(Integer)プロパティに数値セルを使うとエラーになる#2142
Open
NonakaKazuhiro wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Excelアップロード時に、Integer（実体は Long）型プロパティの列へ「数値セル」で整数を入力すると 100.0 のように小数点付き文字列になりパースエラーになる問題（Issue #2135）を解消するPRです。EntityExcelReader の数値セル→文字列変換時に、整数プロパティ向けの変換を追加して不正な形式にならないようにしています。
Changes:
- Excelの数値セル読み取りで、
PropertyDefinitionType.INTEGERの場合に「整数値なら整数文字列（例:100）」として返す分岐を追加 - 既存のBoolean（0/1が0.0/1.0になる）対応と同様に、型に応じた文字列化を強化
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
対応内容
Excelアップロードで整数(Integer)プロパティに数値セルを使うとエラーになる不具合の修正
closes #2135
動作確認・スクリーンショット（任意）
レビュー観点・補足情報（任意）