GEM: ファイルアップロード画面 vs ウィジェットで、検索Formデータが混線する#2063
Merged
xtakahashi-hiroyuki merged 6 commits intoMay 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
ファイルアップロード画面とTOP画面ウィジェット(EntityListParts)の描画が同一リクエスト内で走る際に、SearchFormView を request に格納する属性名が衝突して上書きされる問題(#1976)を回避するため、EntityListParts 側の属性キーを変更して衝突を防ぐPRです。
Changes:
- EntityListParts の JSP(parts / widget)で参照する
SearchFormViewの request 属性名をsearchFormView→listPartsSearchFormViewに変更 MetaEntityListPartsが設定する属性名を同様に変更し、clearAttribute()で後片付けを追加
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| iplass-gem/src/main/resources/META-INF/resources/jsp/gem/generic/search/listWidget.jsp | EntityListParts(Widget) 側で参照する SearchFormView の request 属性キーを変更 |
| iplass-gem/src/main/resources/META-INF/resources/jsp/gem/generic/search/list.jsp | EntityListParts(Parts) 側で参照する SearchFormView の request 属性キーを変更 |
| iplass-gem/src/main/java/org/iplass/mtp/impl/view/top/parts/MetaEntityListParts.java | EntityListParts が request に積む属性キー変更+属性クリア処理を追加 |
7522f68 to
e642a1c
Compare
added 2 commits
May 21, 2026 21:30
h-terazaki
approved these changes
May 22, 2026
yuichi-github
approved these changes
May 22, 2026
xtakahashi-hiroyuki
added a commit
that referenced
this pull request
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
対応内容
closes #1976
バグ原因
ファイルアップロード画面のSearchFormViewデータが、Widget画面処理で別データで上書きされていた
修正内容
上書きしないように(キーを変更。重複しないように)
動作確認・スクリーンショット(任意)
メイン修正
デグレチェック
Widget以外の画面にデグレがないことを確認した
レビュー観点・補足情報(任意)
横展開チェック
iplass-gem/src/main/java/org/iplass/mtp/impl/view/top/partsの中で、今回の問題(以下)と同じ実装がないか、横展開チェックした
→ 問題なし