Skip to content

GEM:多重度が「1」以上 の場合、多重度以上の項目を選択した場合に自動的にトリムされてしまうことを改善#1843

Merged
tei-syou merged 4 commits into
masterfrom
feature/1817-editor-display-multiple
Sep 10, 2025
Merged

GEM:多重度が「1」以上 の場合、多重度以上の項目を選択した場合に自動的にトリムされてしまうことを改善#1843
tei-syou merged 4 commits into
masterfrom
feature/1817-editor-display-multiple

Conversation

@tei-syou

Copy link
Copy Markdown
Contributor

対応内容

多重度が1以上・タイプが「CHECKBOX」または「SELECT」の場合、エディタに選択件数の制限を追加します。
選択数が多重度以上の場合、エラーメッセージを表示します
closed #1817

動作確認・スクリーンショット(任意)

  • 多重度が1の場合、ReferencePropertyEditor、SelectPropertyEditor、StringPropertyEditorのタイプが「CHECKBOX」または「SELECT」の場合、画面表示
  • 多重度が1以上の場合、ReferencePropertyEditor、SelectPropertyEditor、StringPropertyEditorのタイプが「CHECKBOX」または「SELECT」の場合、画面表示
  • 多重度が*の場合、ReferencePropertyEditorのタイプが「CHECKBOX」または「SELECT」の場合、画面表示

レビュー観点・補足情報(任意)

@tei-syou
tei-syou requested a review from Copilot August 29, 2025 06:32
@tei-syou tei-syou self-assigned this Aug 29, 2025

This comment was marked as outdated.

@tei-syou
tei-syou requested a review from Copilot August 29, 2025 08:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds multiplicity validation for SELECT and CHECKBOX display types in property editors. It implements client-side validation to limit the number of selections based on the property's multiplicity setting and displays error messages when the limit is exceeded.

Key changes:

  • Adds JavaScript validation for select elements and checkboxes to enforce multiplicity limits
  • Displays error messages when selection count exceeds the configured multiplicity
  • Implements form validation that prevents submission when multiplicity is violated

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.

File Description
StringPropertyEditor_Edit.jsp Adds multiplicity validation for multiple select elements in string property editor
SelectPropertyEditor_Edit.jsp Adds multiplicity validation for select elements in select property editor
ReferencePropertyEditor_Edit.jsp Adds multiplicity validation for both select and checkbox display types in reference property editor

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tei-syou tei-syou changed the title 多重度チェックを追加 GEM:多重度が「1」以上 の場合、多重度以上の項目を選択した場合に自動的にトリムされてしまうことを改善 Aug 29, 2025
@tei-syou
tei-syou requested a review from hkondoh September 1, 2025 01:38
@tei-syou
tei-syou merged commit 265c354 into master Sep 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GEM:多重度が「1」以上 の場合、多重度以上の項目を選択した場合に自動的にトリムされてしまうことを改善

3 participants