GEM:多重度が「1」以上 の場合、多重度以上の項目を選択した場合に自動的にトリムされてしまうことを改善#1843
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds multiplicity validation for SELECT and CHECKBOX display types in property editors. It implements client-side validation to limit the number of selections based on the property's multiplicity setting and displays error messages when the limit is exceeded.
Key changes:
- Adds JavaScript validation for select elements and checkboxes to enforce multiplicity limits
- Displays error messages when selection count exceeds the configured multiplicity
- Implements form validation that prevents submission when multiplicity is violated
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| StringPropertyEditor_Edit.jsp | Adds multiplicity validation for multiple select elements in string property editor |
| SelectPropertyEditor_Edit.jsp | Adds multiplicity validation for select elements in select property editor |
| ReferencePropertyEditor_Edit.jsp | Adds multiplicity validation for both select and checkbox display types in reference property editor |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
hkondoh
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
対応内容
多重度が1以上・タイプが「CHECKBOX」または「SELECT」の場合、エディタに選択件数の制限を追加します。
選択数が多重度以上の場合、エラーメッセージを表示します
closed #1817
動作確認・スクリーンショット(任意)
レビュー観点・補足情報(任意)