Entity: バリデーションの実行条件を設定可能にする(4.0)#1804
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
エンティティのバリデーションに対して、スクリプトによる実行条件の設定を可能にする機能追加です。
- MetaValidation / ValidationDefinition に
validationSkipScriptプロパティを追加 - ValidationHandler にスクリプトを評価してバリデーションスキップを行う処理を実装
- 管理コンソールのダイアログ・リストにスクリプト編集UIと表示列を追加
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| iplass-core/src/main/java/org/iplass/mtp/impl/validation/ValidationHandler.java | スキップスクリプト評価ロジックを実装 |
| iplass-core/src/main/java/org/iplass/mtp/impl/validation/MetaValidation.java | validationSkipScript プロパティの追加 |
| iplass-core/src/main/java/org/iplass/mtp/entity/definition/ValidationDefinition.java | 定義側へのスクリプトフィールド追加 |
| iplass-core/src/main/java/org/iplass/mtp/impl/validation/MetaValidationRegex.java | スクリプトスキップチェックの統合 |
| iplass-admin/src/main/java/org/iplass/adminconsole/client/metadata/ui/entity/property/validation/ValidationEditDialog.java | スクリプト編集ボタン・テキストエリアを追加 |
| iplass-admin/src/main/java/org/iplass/adminconsole/client/metadata/ui/entity/property/ValidationListPane.java | スクリプト設定状態の表示を追加 |
| iplass-admin/src/main/java/org/iplass/adminconsole/client/metadata/ui/entity/property/ValidationListGridRecord.java | レコードモデルにスクリプトフィールドを追加 |
| iplass-admin/src/main/resources/org/iplass/adminconsole/public/locale/locale_ja.js, locale_en.js | スクリプト編集関連の文言を追加 |
Comments suppressed due to low confidence (3)
iplass-admin/src/main/java/org/iplass/adminconsole/client/metadata/ui/entity/property/ValidationListGridRecord.java:245
- メソッド名に余分な 't' が含まれています。
gettValidationSkipScriptDisplayInfoをgetValidationSkipScriptDisplayInfoに修正してください。
public String gettValidationSkipScriptDisplayInfo() {
iplass-admin/src/main/java/org/iplass/adminconsole/client/metadata/ui/entity/property/ValidationListGridRecord.java:249
- メソッド名に余分な 't' が含まれています。
settValidationSkipScriptDisplayInfoをsetValidationSkipScriptDisplayInfoに修正してください。
public void settValidationSkipScriptDisplayInfo(String value) {
iplass-core/src/main/java/org/iplass/mtp/impl/validation/MetaValidation.java:102
- [nitpick] 新規メソッドなので、処理内容や戻り値の説明を追加した JavaDoc コメントを付与すると保守性が向上します。
public String getValidationSkipScript() {
hkondoh
approved these changes
Jul 18, 2025
hkondoh
approved these changes
Jul 18, 2025
xnie-yabin2
added a commit
that referenced
this pull request
Jul 22, 2025
* Entity: バリデーションの実行条件を設定可能にする * Copilot指摘対応 * EntityExplorerのExport(Csv)の修正 * 指摘対応 * ValidationSkipScriptの「Null」判断ロジックを追加します
xnie-yabin2
added a commit
that referenced
this pull request
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
対応内容
fixes #1768
動作確認・スクリーンショット(任意)
レビュー観点・補足情報(任意)