Commons FileUpload 2.0.0-M4 バージョンアップ#1799
Merged
Merged
Conversation
- org.apache.commons:commons-fileupload2-jakarta-servlet6 2.0.0-M2 -> 2.0.0-M4 - (推移依存ライブラリ)commons-io:commons-io 2.15.1 -> 2.19.0 - commons-fileupload バージョンアップによるコンパイルエラー対応
Contributor
There was a problem hiding this comment.
Pull Request Overview
このPRでは、Commons FileUploadおよび関連ライブラリのメジャーアップデートに伴い、Gradle依存性とファイルアップロード処理のコンパイルエラー対応を行っています。
sharedlibs.gradleでcommons-ioとcommons-fileupload2-jakarta-servlet6のバージョンを更新getString()メソッドで発生するIOExceptionをキャッチして例外ラップを追加
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| sharedlibs.gradle | commons-ioとcommons-fileupload2-jakarta-servlet6のバージョンをそれぞれ2.16.1→2.19.0、2.0.0-M2→2.0.0-M4に更新 |
| CommonsFileuploadMultipartRequestParameter.java | delegate.getString()およびdelegate.get()でのIOExceptionをキャッチしてRuntimeExceptionにラップする処理を追加 |
- fix typo
- commons-fileupload のmilestone版利用しているコメントを修正 - IOException 発生時のラップ例外を修正
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
対応内容
動作確認・スクリーンショット(任意)
レビュー観点・補足情報(任意)