Expose cache stats#79
Merged
Merged
Conversation
peterxcli
reviewed
Apr 21, 2026
| } | ||
|
|
||
| void ConditionCacheStore::RecordAccess(bool hit) { | ||
| total_accesses.fetch_add(1, std::memory_order_relaxed); |
Owner
Author
There was a problem hiding this comment.
Yes. Opus generated the code and I think it's fine. For cache access stats we don't need to be 100% precise, but I could change it
|
|
||
| auto store = ConditionCacheStore::GetOrCreate(context); | ||
| auto entry = store->Lookup(context, key); | ||
| store->RecordAccess(entry != nullptr); |
Collaborator
There was a problem hiding this comment.
note: this should be refactored after we introduce #78, otherwise the lookup hit doesnt mean query can actually use them to reduce the IO and materalize overhead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #59
This PR exposes cache stats: overall memory consumption, cache hit and total access count.