fix: count distinct top-level fields against dataSkippingNumIndexedCols#4466
Draft
rtyler wants to merge 3 commits into
Draft
fix: count distinct top-level fields against dataSkippingNumIndexedCols#4466rtyler wants to merge 3 commits into
rtyler wants to merge 3 commits into
Conversation
rtyler
added
binding/rust
rtyler
force-pushed
the
fix/data-skipping-3172
branch
from
38bf806 to
d1de4ae
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4466 +/- ##
==========================================
+ Coverage 78.89% 78.91% +0.01%
==========================================
Files 173 173
Lines 59697 59777 +80
Branches 59697 59777 +80
==========================================
+ Hits 47096 47171 +75
- Misses 9983 9988 +5
Partials 2618 2618 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: R Tyler Croy <rtyler@brokenco.de>
The per-file stats budget (default 32) was being consumed one parquet leaf at a time, so a single top-level column with many nested fields exhausted the budget and starved later top-level columns of stats. This sloptastic 🦜 PR attempts to match the Delta/Spark implementation by using N distinct top-level fields and collecting stats for every leaf under them; partition columns no longer consume a slot. The negative test case was added first and then I validated that the tests fail in accordance with the suggestions made by posters in the original issue Fixes delta-io#3172 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: R Tyler Croy <rtyler@brokenco.de>
rtyler
force-pushed
the
fix/data-skipping-3172
branch
from
d1de4ae to
c93681d
Compare
See delta-io#3172 Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The per-file stats budget (default 32) was being consumed one parquet
leaf at a time, so a single top-level column with many nested fields
exhausted the budget and starved later top-level columns of stats.
This sloptastic 🦜 PR attempts to match the Delta/Spark
implementation by using N distinct top-level fields and
collecting stats for every leaf under them; partition columns no
longer consume a slot.
The negative test case was added first and then I validated that the
tests fail in accordance with the suggestions made by posters in the
original issue
Fixes #3172
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com