DLPX-96941 Replace ntpsec with chrony (delphix-platform changes)#556
Merged
manoj-joseph merged 1 commit intoMay 8, 2026
Merged
Conversation
b345df4 to
72b7386
Compare
8629f1e to
297d9f4
Compare
8cddf73 to
201a01b
Compare
201a01b to
877552c
Compare
prakashsurya
approved these changes
May 5, 2026
prakashsurya
left a comment
Contributor
There was a problem hiding this comment.
I haven't fully reviewed test cases, etc.. so I'll rely on you to ensure that's comprehensive, etc.. otherwise, LGTM.
nealquigley
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The Delphix appliance previously used
ntpsecas its NTP daemon (and before that, the legacyntppackage). Both packages are being replaced withchrony(DLPX-96940/96941/96942), motivated by two factors:ntpsecandntprespond to NTP mode 6/7 queries, exposing sensitive system information (OS version, kernel, stratum, etc.) that can aid further attacks against the system.chronydoes not support these query modes by default, eliminating the disclosure.chronyis the default NTP daemon. Making this switch now avoids duplicating the migration effort at that time.Companion PRs
This PR is part of a set of four that must merge together:
Problem
The Delphix Engine's Debian package declared
ntpsecas a dependency indebian/rules. This needs to be replaced withchrony.Solution
One-line change in
debian/rules:ntpsecreplaced withchronyin theDEPENDSlist.Testing Done
Full appliance build including all three companion PRs verified on Jenkins:
NtpServerMonitoringTestflakiness (fixed; see second set of runs below)