Skip to content

TOOL-28181 internal-dev not configured with mirror apt sources#827

Merged
sebroy merged 2 commits into
developfrom
dlpx/pr/sebroy/f5424b52-ac53-48ae-959c-3cc1cb14abf2
May 8, 2026
Merged

TOOL-28181 internal-dev not configured with mirror apt sources#827
sebroy merged 2 commits into
developfrom
dlpx/pr/sebroy/f5424b52-ac53-48ae-959c-3cc1cb14abf2

Conversation

@sebroy

@sebroy sebroy commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

The fix for TOOL-1348 included logic to configure the internal-dev variant apt sources, but there’s a missing chroot in that configuration logic, which causes the configuration to apply to the build server instead of the VM being created.

This was tested by creating an internal-dev VM and verifying that /etc/apt/sources.list.d/delphix.list is present on it.

@sebroy sebroy force-pushed the dlpx/pr/sebroy/f5424b52-ac53-48ae-959c-3cc1cb14abf2 branch from 7561c62 to 3a0a486 Compare June 30, 2025 20:52
@sebroy sebroy marked this pull request as ready for review June 30, 2025 20:53

@mszak-perforce mszak-perforce left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sebroy sebroy force-pushed the dlpx/pr/sebroy/f5424b52-ac53-48ae-959c-3cc1cb14abf2 branch from 3a0a486 to e437d76 Compare May 7, 2026 23:05
@sebroy sebroy enabled auto-merge (squash) May 8, 2026 12:11
@sebroy sebroy requested review from dbjwhs-perforce and removed request for tonynguien May 8, 2026 12:25
@sebroy sebroy merged commit 5ee9f6e into develop May 8, 2026
3 of 5 checks passed
@sebroy sebroy deleted the dlpx/pr/sebroy/f5424b52-ac53-48ae-959c-3cc1cb14abf2 branch May 8, 2026 16:20

@dbjwhs-perforce dbjwhs-perforce left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# sources configuration that points to our internal Ubuntu mirror.
#
if [[ $APPLIANCE_VARIANT = "internal-dev" ]]; then
cat <<-EOF >/etc/apt/sources.list.d/delphix.list

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants