fix: correct timeout check logic for IoRing::jobsToProc#404
Merged
Conversation
KuribohG
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a logic error in IoRing's timeout check mechanism. The issue was that
lastCheck_was being assigned at the same time asnow, making the!lastCheck_condition always false. This prevented the timeout waiting logic from working correctly whenioDepthis negative.The fix separates the time acquisition from the state assignment, ensuring that the first-time check works properly and the timeout mechanism functions as intended.
This change affects the
getJobs()method insrc/fuse/IoRing.cc, specifically the batch processing logic whenioDepthis negative.