fix(sync): handle truncate/extend operations correctly in syncing#403
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens syncing/forwarding behavior to correctly handle truncate/extend operations when forwarding updates to a successor target in SYNCING state.
Changes:
- Reject truncate/extend updates that are marked as
options.isSyncingon the storage server side. - Adjust
ReliableForwarding’sreadForSyncingcondition to ensure truncate/extend operations trigger full-chunk read/forwarding during syncing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/storage/service/StorageOperator.cc |
Adds validation to reject truncate/extend when options.isSyncing is set. |
src/storage/service/ReliableForwarding.cc |
Updates syncing-forward read decision logic to include truncate/extend (including the length == chunkSize extend case). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.