[bugfix] get_allocate_tasks: more than 3 allocator have compact tasks will cause crash#311
Closed
YuqqiZhou wants to merge 1 commit into
Closed
[bugfix] get_allocate_tasks: more than 3 allocator have compact tasks will cause crash#311YuqqiZhou wants to merge 1 commit into
YuqqiZhou wants to merge 1 commit into
Conversation
YuqqiZhou
changed the title
Collaborator
|
The tinyvec::ArrayVec<[GroupId; 3]> does not mean the vec can only hold 3 elements. It indicates that when the number of elements does not exceed 3, the data is stored on the stack, and it is expected not to crash. If you encounter a crash, feel free to share the specific logs. |
Collaborator
|
I realized I used the wrong data structure—I should have used The new fix is submitted at #401. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the magic number 3 to CHUNK_SIZE_NUMBER