Skip to content

Modify headers in source_basis to lower the dependency's depth#7364

Merged
mohanchen merged 3 commits into
deepmodeling:developfrom
Critsium-xy:remove_dead_psi_includes
May 19, 2026
Merged

Modify headers in source_basis to lower the dependency's depth#7364
mohanchen merged 3 commits into
deepmodeling:developfrom
Critsium-xy:remove_dead_psi_includes

Conversation

@Critsium-xy
Copy link
Copy Markdown
Collaborator

@Critsium-xy Critsium-xy commented May 19, 2026

Why so many #define private public in test files😅

@Critsium-xy Critsium-xy changed the title Remove useless headers in source_basis Modify headers in source_basis to lower the dependency's depth May 19, 2026
@Critsium-xy Critsium-xy marked this pull request as ready for review May 19, 2026 05:55
@mohanchen
Copy link
Copy Markdown
Collaborator

The original tests are not well written. Good job.

@mohanchen mohanchen added Refactor Refactor ABACUS codes The Absolute Zero Reduce the "entropy" of the code to 0 labels May 19, 2026
@mohanchen mohanchen merged commit f09748a into deepmodeling:develop May 19, 2026
15 checks passed
@Critsium-xy Critsium-xy deleted the remove_dead_psi_includes branch May 19, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Refactor ABACUS codes The Absolute Zero Reduce the "entropy" of the code to 0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants