Repository navigation
The temporal bench's chat check scores the name the question asks for - #997
Merged
WaylandYang merged 2 commits intoSep 29, 2026
Merged
WaylandYang merged 2 commits into
WaylandYang merged 2 commits into
Conversation
Signed-off-by: dada-yan <BinjunYann@gmail.com>
WaylandYang
approved these changes
Sep 29, 2026
WaylandYang
left a comment
Contributor
There was a problem hiding this comment.
Approving. Thanks @Maya-Kid.
Reviewed at 557aa6e. The rule is right: what the question asks for has to appear, and a name in not only fails the answer when it comes first. I walked the substring cases (28000 inside 128000, an expect that contains a not name, two that start at the same place) and each lands where it should. Re-scoring the four kept runs without a model call was a good way to show it, and reading all 19 changed verdicts is what makes the numbers usable.
The limits are stated where a reader will find them, and the README says the older chat numbers used the earlier rule. Nothing to change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raised in the #986 review. The chat check counts any name in
notas a wrong answer. An answer that names the right lead and then says who took over is therefore scored as wrong.Problem
chatVerdictinscripts/bench/temporal.mjspasses an answer only whenexpectappears and no name innotappears anywhere in it.superseded by X [m]), and the model repeats it: "Li Si led Project Aurora in August 2024 — their tenure as lead ran from 2024-07-05 until 2025-09-01, when Zhou Qi took over [3][2]." That answer is right, yet it is scored as wrong.lin-zhao-correction.mdrecords 32,000 CNY from 2024-02-20".Change
expectpasses whenexpectappears and no name innotappears before it. When two candidates start at the same place, the longer one counts.expect: nullis scored as before: any name innotfails it. There is no order to compare, and a negated sentence still fails, as the README already records.notamong the facts held at that moment is a wrong answer.Verification
No model call is needed. The four chat runs measured for #986 (dev twice, then the branch twice) kept every reply in their reports. I re-scored them with
chatVerdicttaken verbatim from each version oftemporal.mjs. The counts follow the report's own rules: known gaps and errors are kept apart, and none of these runs had either.aurora-lead-2024-08, quoted above;lin-zhao-salary-record-wave1;helios-lead-record-wave2: "recorded as led by L. Si (Li Si) … the same person is later recorded under the name Li Si".aurora-lead-record-wave2-at-2025-10in the second branch run. It names Li Si, but also says Zhou Qi's start was already on record before the third lead arrived.expect: null, a name innotfails;node --check scripts/bench/temporal.mjspasses. CI does not run the bench scripts.