Repository navigation
Follow-up tests from the #975 and #986 reviews - #993
Merged
WaylandYang merged 2 commits intoSep 29, 2026
Merged
WaylandYang merged 2 commits into
WaylandYang merged 2 commits into
Conversation
…ed end names Signed-off-by: dada-yan <BinjunYann@gmail.com>
WaylandYang
approved these changes
Sep 29, 2026
WaylandYang
left a comment
Contributor
There was a problem hiding this comment.
Approving. Thanks @Maya-Kid, these are the tests the two reviews asked for.
Reviewed at 83c2244. Tests only, and each one builds its case the way it arises in use. Running every new check against the code with the pinned behaviour changed, and showing what it fails with, is what I would ask for, so thank you for doing it unasked.
One note, no change needed: assert!(zhou_a < sun_a) relies on two ids made in a row being ordered. If that ever stops holding the assert fails loudly, which is the right way for it to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests asked for when #975 and #986 landed. Tests only; no code changes.
A row a person wrote survives step 0 (#975)
At merge, step 0 of materialization gained the guard step 2 has: it retires only computed rows (
from_statement_idorimplied). The new testa_moment_marks_its_state::a_row_a_person_wrote_is_kept_when_a_single_date_merged_into_itbuilds the case the way it arises:from_statement_id.from_statement_id. The other is written as a computed row (added1,merged1).retired1). The person's row stays live with its date.A
bind_tohelper binds a phrase to a property other thanworks_for.The closer a derived end names (#986)
The new test
a_fact_says_where_its_dates_came_from::a_closer_is_the_row_the_timeline_closed_withruns onleads, which is inverse functional (one lead per project):temporal::desired_endsalso takes that row first when it sorts the candidates.A closer with no live evidence (#986)
chat_graph_citation_tests::a_fact_line_says_when_a_date_is_not_the_passagesnow continues after Zhou Qi's document is deleted:entity_facts,neighborsandtimeline, and on apaths_betweenhop, Li Si's line readssuperseded by Zhou Qiwithout a number.Verification
Run in containers on a Linux host: Rust 1.98.1 and PostgreSQL 16 with pgvector.
Each new check was also run with the code it pins changed, one change at a time. Each fails there:
retired: 2n.id DESCfirst_live_evidencereading deleted documentssuperseded by Zhou Qi [2]On this branch:
cargo fmt --all --checkandcargo clippy --locked --workspace --all-targets -- -D warningsare clean.UTOPIA_TEST_REQUIRE_PDFTOTEXT=1 cargo test --locked --workspacepasses: 1283 passed, 0 failed.