Skip to content

Revert "Fix JNI memory safety issues in native utils (#3825)"#3868

Merged
xyang16 merged 1 commit into
deepjavalibrary:masterfrom
xyang16:revert
Jul 15, 2026
Merged

Revert "Fix JNI memory safety issues in native utils (#3825)"#3868
xyang16 merged 1 commit into
deepjavalibrary:masterfrom
xyang16:revert

Conversation

@xyang16

@xyang16 xyang16 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Description

This reverts commit 029150d. #3825 is not necessary because GetObjectVecFromJHandles is an internal function, the jhandles is guaranteed to be valid. Adding the validation will create unnecessary overhead.

@xyang16
xyang16 requested review from a team and zachgk as code owners July 15, 2026 16:54

@Majid-Taheri Majid-Taheri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@access2rohit access2rohit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xyang16
xyang16 merged commit af1d0b8 into deepjavalibrary:master Jul 15, 2026
5 checks passed
@xyang16
xyang16 deleted the revert branch July 15, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants