[Deepin-Kernel-SIG] [linux 6.6.y] [deepin] arm64: decrease NR_CPUS to 1024#1752
[Deepin-Kernel-SIG] [linux 6.6.y] [deepin] arm64: decrease NR_CPUS to 1024#1752opsiff wants to merge 1 commit into
Conversation
deepin inclusion category: performance CONFIG_NR_CPUS=4096 clearly over our all desktop/server/hpc users requirement, limit it to a possible value to more match cacheline and save memory. Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the Deepin ARM64 desktop kernel defconfig to reduce the configured maximum CPU count from 4096 to 1024 in order to better match actual hardware requirements and reduce memory/cache overhead. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider explicitly justifying the choice of 1024 (vs e.g. 256 or 512) in the commit message with expected CPU count ranges for supported Deepin arm64 desktop deployments, so future maintainers understand why this value was selected.
- If there are other Deepin arm64 defconfigs (e.g., server/HPC variants) that still assume CONFIG_NR_CPUS=4096, it may be worth checking and aligning those where appropriate to avoid surprising differences in CPU limits between flavors.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider explicitly justifying the choice of 1024 (vs e.g. 256 or 512) in the commit message with expected CPU count ranges for supported Deepin arm64 desktop deployments, so future maintainers understand why this value was selected.
- If there are other Deepin arm64 defconfigs (e.g., server/HPC variants) that still assume CONFIG_NR_CPUS=4096, it may be worth checking and aligning those where appropriate to avoid surprising differences in CPU limits between flavors.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
有没有前后对比数据 |
There was a problem hiding this comment.
Pull request overview
Reduces the maximum compiled-in CPU count for the Deepin arm64 desktop kernel configuration to lower per-CPU memory overhead and potentially improve cache behavior.
Changes:
- Lower
CONFIG_NR_CPUSindeepin_arm64_desktop_defconfigfrom4096to1024.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| CONFIG_SCHED_CLUSTER=y | ||
| CONFIG_SCHED_SMT=y | ||
| CONFIG_NR_CPUS=4096 | ||
| CONFIG_NR_CPUS=1024 |
before: after: |
请将对比数据（和对应的内核base commit）更新到提交信息中，以便回溯 /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Avenger-285714 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deepin inclusion
category: performance
CONFIG_NR_CPUS=4096 clearly over our all desktop/server/hpc users requirement, limit it to a possible value to more match cacheline and save memory.
Summary by Sourcery
Build: