Add macOS/Linux launcher script#12
Conversation
- WebM sources save as .mp4 (edit.py always encodes h264/aac, which a WebM container rejects); .mp4/.mov/.mkv keep their source suffix. - Print a plain-language notice when a WebM input is saved as .mp4. - Delete broken/partial output on failure; treat a zero-byte or missing result as a failure even on exit code 0. Cut/concat temp-dir isolation is preserved. - Surface the underlying ffmpeg reason in error messages, not just the generic "[edit] X failed:" summary. - Trim START no longer accepts "end" (only the end does). - Reject negative time values in the time validators. - Use shlex.join for an accurate command preview (still list-form exec). - Catch EOFError alongside KeyboardInterrupt for a clean exit.
- run_edit now surfaces the last non-status [edit] line, so actionable errors without the word "failed" (e.g. "normalize-audio requires an input with an audio stream.") are shown instead of a bare exit code. - EOF (Ctrl+D / piped run) is handled inside the loop so a failed edit followed by EOF still exits non-zero instead of always exiting 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- WebM sources now save as .mkv instead of .mp4, so operations that copy audio (resize, rotate, sharpen, …) work with Vorbis streams. - Only delete output on failure if this run created the file, avoiding collision with a pre-existing valid output from a prior run. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a8c25991d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,4 @@ | |||
| #!/usr/bin/env bash | |||
| set -e | |||
| cd "$(dirname "$0")" | |||
There was a problem hiding this comment.
When this launcher is installed via a symlink, such as from ~/bin or another PATH directory, dirname "$0" points at the symlink directory rather than the repository root. The subsequent python3 scripts/easy_edit.py then looks for scripts/easy_edit.py next to the symlink, so even run_easy_edit.sh --version fails outside the repo. Resolve the real script path before cd-ing, or invoke easy_edit.py via an absolute path derived from the resolved location.
Useful? React with 👍 / 👎.
2 participants
Closed — superseded by PR #13 (clean branch from latest main, no stale PR #11 history).
Generated by Claude Code