Int32 repro original#581
Merged
Merged
Conversation
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
Closed
thehoul
reviewed
Nov 10, 2025
thehoul
reviewed
Nov 10, 2025
thehoul
reviewed
Nov 10, 2025
thehoul
reviewed
Nov 10, 2025
jbsv
marked this pull request as ready for review
November 10, 2025 17:23
|
|
thehoul
force-pushed
the
int32-repro-original
branch
2 times, most recently
from
November 12, 2025 14:58
a9173e5 to
537820e
Compare
thehoul
requested changes
Nov 18, 2025
thehoul
left a comment
thehoul
left a comment
Contributor
There was a problem hiding this comment.
I also reviewed the comment from Yolan on #579 that were relevant for this PR.
I will take some time to
- Make sure all int in the code have been switched to uint32. @ValeriodeSa how certain are you to have covered everything?
- Test the protobuf serialiazation/deserialiazation of uint32
jbsv
force-pushed
the
int32-repro-original
branch
from
November 19, 2025 14:35
79dda03 to
fa56084
Compare
thehoul
force-pushed
the
int32-repro-original
branch
from
November 19, 2025 15:06
7be5ef8 to
332e7a8
Compare
jbsv
approved these changes
Nov 19, 2025
jbsv
left a comment
jbsv
left a comment
Contributor
There was a problem hiding this comment.
LGTM, although we should try to keep sonar happy.
jbsv
force-pushed
the
int32-repro-original
branch
from
November 24, 2025 08:33
8e9bdc2 to
fa56084
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.