Repository navigation
Stage 3.1.17 custom-build support after the real tag - #290
Merged
Merged
Conversation
This was referenced Nov 20, 2026
ODevStudio
marked this pull request as ready for review
November 20, 2026 14:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hold: Real Tag Required
This is an intentionally held rollout draft, not another original PR to merge during pre-tag preparation. Do not merge/deploy it until the separately authorized real
v3.1.17tag points to approved candidate1efca39865dea78c7da0b15c845da6ab30228e8f, then regenerate/reverify catalogs against that real tag.Pre-tag preparation is merged in #289. No real/shared/GitHub
v3.1.17tag or release has been created by this work.Summary
v3.1.17support to the existing registry, three plugin manifests, Worker allowlist and both generated catalogs.v3.1.16; direct browser selection ofv3.1.17remains rejected until separate activation.plugins/pressensor/patches/v3.1.17.patchseparately, byte-identical to approved main's moving patch: SHA-256a820251bc97b93cfacf58c42b3ea6c3a9699b5a8cf545cd5493e72908460c16c. Existingv3.1.16.patchremains9544f92b459288f332038e43cd061e4984575e32aa14ce2c436b603b4ebb80b6.3.1.17-main-customversus3.1.17-custom, source/builder provenance, signing generation, permissions,BUILDER_REF=main, trusted dispatch and publication fences.Prospective Validation
A standalone clone with its own Git database, no remotes, no alternates/commondir and no Git-directory overrides was used. Its synthetic
v3.1.17points exactly to approved main1efca39865dea78c7da0b15c845da6ab30228e8f. Both catalogs were generated there through the existing APIs; only reviewed outputs returned to this branch. The shared repository tag remained absent.Passed locally in that fixture:
The Bash argument contract passed under host Git Bash; automatic Linux draft CI also passed actual old/new plugin/profile compilation. No local ESP-IDF rebuild was run.
Remaining Gates
Real-tag regeneration and patch/profile verification, production scoped-App lookups, hosted main/tagged version/source/builder identity, binary/ZIP hashes, production signatures and saved-build provenance remain required. No production job, assignment, deployment, secret change, flash, signing or publication was performed.
Public-default activation is a separate dependent draft after this support stage; it additionally requires release publication and service readiness. Existing signed recovery/history assets remain immutable.
Combined-Integration CI Coverage
The existing verifier compiles Pressensor alone, so this draft also runs the normal custom builder with both Pressensor and Grind-by-weight for
mainand prospectivev3.1.17. These two matrix entries use disposable job-local signing keys, explicit candidate builder pins, candidate main-source pins, and an explicitly resolved tagged source SHA. No production upload, dispatch or publication path is added.The extended argument contract passed all ten plugin/ref cases under host Git Bash, including distinct candidate/tag SHAs, older single-verifier cases and a non-Pressensor case. Actual combined compilation is an automatic exact-head CI gate, not a result inferred from selection-only unit tests.
Final Exact-Head CI Evidence
Head
6bdde226d15eb49842e0af6a37ee54a66333ef3fpassed all relevant checks:Actual combined Pressensor/Grind-by-weight builds succeeded for main (job 136311638669) and prospective v3.1.17 (job 136311638850); disposable-key generation and firmware compilation both passed. This is compilation evidence, not production signing or hardware acceptance.
The draft remains intentionally unmerged. No real v3.1.17 tag or release exists; the public default remains v3.1.16. The real-tag and production-readiness gates above are unchanged. Public-default activation remains separately held in #291.