feat: multi-address client support and stale connection fix on reconnect#2136
Open
gdcodedev wants to merge 4 commits into
Open
feat: multi-address client support and stale connection fix on reconnect#2136gdcodedev wants to merge 4 commits into
gdcodedev wants to merge 4 commits into
Conversation
Client: - Allow comma-separated server addresses in the GUI field (e.g. "192.168.1.1, myserver.ddns.net"). The client cycles through each address automatically when a connection attempt fails, enabling seamless fallback between LAN IP and external hostname after a network change. - Rename "Server IP:" label to "Server IP / Hostname:" to clarify that DNS hostnames are accepted. - Add Client::setServerAddress() to allow address cycling between reconnect attempts without recreating the client object. Server: - When a client reconnects with the same screen name while the previous connection is still registered (common after a network change), replace the stale connection instead of rejecting the new one. Previously the server would refuse the reconnecting client, leaving it unable to re-establish until manually restarted.
gdcodedev
force-pushed
the
feature/multi-address-reconnect-fix
branch
from
8eb9780 to
58fd5b5
Compare
MSBuild (Visual Studio) places binaries in bin/Release/ while single-config generators (Ninja, Makefiles) use bin/ directly. Introduce BARRIER_INSTALLER_BIN_DIR that selects the right path based on CMAKE_CONFIGURATION_TYPES.
Using else-if chains with paths containing parentheses (e.g. 'Program Files (x86)') caused the batch parser to interpret the closing paren as the end of the if-block, producing the error '\Inno was unexpected at this time.' Use sequential if+goto instead, which avoids nested parentheses entirely. Also switch from hardcoded C:\Program Files (x86) to %ProgramFiles(x86)% for correctness on non-English Windows.
x64compatible was introduced in Inno Setup 6.3.0. Inno Setup 6.2.x (used in CI) only recognises x64, arm64. Using x64 is equivalent for 64-bit Windows builds and compatible with all Inno Setup 6.x releases.
|
Barrier is no longer in development. Check out Deskflow (upstream) or Input Leap (fork). https://github.com/deskflow/deskflow If this is still an issue in those projects, we would appreciate a cross-post of this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan