Skip to content

Record validation visualisation vignette decision#72

Merged
carmen-cabrera merged 1 commit into
mainfrom
codex/record-validation-viz-vignette-decision
Jun 22, 2026
Merged

Record validation visualisation vignette decision#72
carmen-cabrera merged 1 commit into
mainfrom
codex/record-validation-viz-vignette-decision

Conversation

@fcorowe

@fcorowe fcorowe commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • record that the exported validation visualisation functions should be used in the existing validation vignette
  • clarify that there will not be a separate validation-visualisation vignette
  • mark the visual prototype notebook and rendered output as internal design/review notes

Validation

  • git diff --check
  • rendered notes/project-management/VALIDATION_VISUAL_PROTOTYPES.qmd

@fcorowe fcorowe requested a review from carmen-cabrera as a code owner June 19, 2026 10:24
@carmen-cabrera

carmen-cabrera commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

OK with these decisions on how the visual propotypes should be integrated into the vignettes.

However, I believe the revisions to the visualisation prototypes that I proposed in PR #71 have not been integrated into the visualisation functions. Not sure if you agree/disagree with these revisions @fcorowe

@fcorowe

fcorowe commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator Author

The visualisation changes you suggested in PR #71 have been integrated into the package plotting functions, not only the prototype notebook.

The confusion may be that PR #72 only records the decision that these functions should be used in the existing validation vignette and not in a separate visualisation vignette. It does not repeat the function-level changes from PR #71.

Those changes were included in PR #71 and squash-merged into main, including updates to the comparison labelling, Level 1 colour/legend treatment, residual/scatter labelling, residual-band legends, Level 4 JSD explanation, and Level 5 residual-structure plot defaults.

So, please feel free to approve this PR.

@carmen-cabrera carmen-cabrera merged commit 172a8e9 into main Jun 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants